Skip to content

Instantly share code, notes, and snippets.

@betbether

betbether/ColdStaking.sol Secret

Last active October 13, 2018 07:56
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save betbether/187a40779c6ccb4c9931a789f78aa278 to your computer and use it in GitHub Desktop.
Save betbether/187a40779c6ccb4c9931a789f78aa278 to your computer and use it in GitHub Desktop.
Download ZIP
Callisto Coldstaking Bug: Need to check user active status when call claim method
Raw
ColdStaking.sol
1. Issue 1: Method: claim()
Missing check user inactive.
If user inactive more than two years, this method still return reward when she claims
Need to check:
require(Timestamp <= staker[msg.sender].time.add(max_delay))
2. Issue 2: Method function new_block() public
This is public method and is not payable but there is statment:
StakingRewardPool = address(this).balance.sub(TotalStakingAmount + msg.value); //fix rewards pool for this block.
The method is not payable so how this statement work?
And if we ant to call this method from external, we cannot send CLO
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment