Talks on how to do them better.
- Stacy Morse, PyCon 2018
- Code Crit Methodology
- Nina Zakharenko, DjangoCon US 2018
- Slides
- Michael Lynch, PyGotham 2018
- Slides
- Finding bugs is only one purpose of many
- Bonding/learning opportunity for teammates
- Use style guide, enforced by linters, formatters, and CI
- Offer code examples as help, not gatekeeping
- Avoid "you"; prefer "we", "what about", passive voice
- Give feedback via requests, not commmands
- A series of short plays from PyGotham 2017
- "We have pretty code, but it does dumb things"
- Easy to get blocked on hypothetical architecture changes
- Poor communication and knowledge sharing seems to be the root problem
- Do initial reviews in person
- Teach best practices via pair programming
- Smaller commits w/ good messages are easier to review
- Use linters to catch style errors
Thanks for this!