Created
October 29, 2017 08:29
-
-
Save bitcoinbrisbane/8956e33489ad1e47fbe317726f16bd39 to your computer and use it in GitHub Desktop.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Changes | |
Unit tests around new "change" methods. | |
Implement fall back function for payable | |
Explicty set access modifiers | |
Change some methods to use safe math (must have been missed) | |
# Comments | |
Safe math now added | |
Good use of modifiers | |
Does gas price need to be public? [282] | |
Maybe use getRate or similar function in calculateTokenAmount [408] to calcuate the ranges. | |
## Concerns | |
1. changeTokenReward [332] could allow a change during a sale. | |
2. Not sure if we require setSold [339]. Does not seem to be called by the contract. | |
3. No unit test on calculateTokenAmount. Seems to be a critical function. | |
# Code coverage | |
Added missing unit tests | |
1. changeTokenReward | |
2. getTokenBalance | |
3. getRate | |
4. calculateTokenAmount |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment