(Note taker arrived late)
Frustrations/Issues:
-
Commenting when making edits would be more effective - "Be the change you want to see in the code"
-
Over-broad notification - Stash adds you to everything you ever touched for notifications
-
Typo and formatting nitpicks - "This whitespace is off."
-
Non-functional comments - personal or other poorly defined stylistic preferences/suggestion
-
Friction during code review process
-
Siloing - reviewers not being familiar with other areas or being unfriendly from reviews outside their prefered colaborators
-
Lack of trust (due to trolling poor tone in comments or due to over-investment in created implementation)
-
Too informal or overly formalized process
-
Lack of clarity about the purpose or design of the change (spec and other planning docs) - High WTFs per minute
Ideas and Potential solutions:
-
rubber ducky
-
Ask for early feedback from one person
-
Get early feedback on spec before implementation to avoid "calling their baby ugly"
-
Having people who write spec not be allowed to write code
-
Link to JIRA
-
Add spec in commit message
-
Talk in person or via video
-
Automated linting and fixing, code style enforcement (MD lint)
-
Comment severity classification: NITPICK, BLOCKER, (general)
-
Office hours (video or in-person) for PR discussion
-
Github PR template
-
(Wish there was) Github comment template/suggestion
-
Meta-review that reviews CR for how the process went
-
Small teams make things easier
-
(Stash) Notify groups of users but pseudo user that points to a DL user.
-
(Github) ".codeowners" file controls who is requested to review