Created
April 27, 2020 18:53
-
-
Save bmw/a88429687f4aed13e300fafdad85ce30 to your computer and use it in GitHub Desktop.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diff --git a/certbot-nginx/certbot_nginx/configurator.py b/certbot-nginx/certbot_nginx/configurator.py | |
index 95715916d..fe5c7da35 100644 | |
--- a/certbot-nginx/certbot_nginx/configurator.py | |
+++ b/certbot-nginx/certbot_nginx/configurator.py | |
@@ -1107,7 +1107,7 @@ class NginxConfigurator(common.Installer): | |
########################################################################### | |
def get_chall_pref(self, unused_domain): # pylint: disable=no-self-use | |
"""Return list of challenge preferences.""" | |
- return [challenges.HTTP01, challenges.TLSSNI01] | |
+ return [challenges.HTTP01] | |
# Entry point in main.py for performing challenges | |
def perform(self, achalls): | |
diff --git a/certbot-nginx/certbot_nginx/http_01.py b/certbot-nginx/certbot_nginx/http_01.py | |
index 70147a433..4dcc5324f 100644 | |
--- a/certbot-nginx/certbot_nginx/http_01.py | |
+++ b/certbot-nginx/certbot_nginx/http_01.py | |
@@ -29,10 +29,10 @@ class NginxHttp01(common.ChallengePerformer): | |
:param list indices: Meant to hold indices of challenges in a | |
larger array. NginxHttp01 is capable of solving many challenges | |
at once which causes an indexing issue within NginxConfigurator | |
- who must return all responses in order. Imagine NginxConfigurator | |
- maintaining state about where all of the http-01 Challenges, | |
- TLS-SNI-01 Challenges belong in the response array. This is an | |
- optional utility. | |
+ who must return all responses in order. Imagine | |
+ NginxConfigurator maintaining state about where all of the | |
+ challenges, possibly of different types, belong in the response | |
+ array. This is an optional utility. | |
""" | |
diff --git a/certbot-nginx/certbot_nginx/tests/configurator_test.py b/certbot-nginx/certbot_nginx/tests/configurator_test.py | |
index 19624a7a2..237e22d8f 100644 | |
--- a/certbot-nginx/certbot_nginx/tests/configurator_test.py | |
+++ b/certbot-nginx/certbot_nginx/tests/configurator_test.py | |
@@ -97,7 +97,7 @@ class NginxConfiguratorTest(util.NginxTest): | |
errors.PluginError, self.config.enhance, 'myhost', 'unknown_enhancement') | |
def test_get_chall_pref(self): | |
- self.assertEqual([challenges.HTTP01, challenges.TLSSNI01], | |
+ self.assertEqual([challenges.HTTP01], | |
self.config.get_chall_pref('myhost')) | |
def test_save(self): | |
diff --git a/certbot-nginx/certbot_nginx/tests/http_01_test.py b/certbot-nginx/certbot_nginx/tests/http_01_test.py | |
index 41c4b95fc..c6d35b808 100644 | |
--- a/certbot-nginx/certbot_nginx/tests/http_01_test.py | |
+++ b/certbot-nginx/certbot_nginx/tests/http_01_test.py | |
@@ -73,11 +73,11 @@ class HttpPerformTest(util.NginxTest): | |
self.http01.add_chall(achall) | |
acme_responses.append(achall.response(self.account_key)) | |
- sni_responses = self.http01.perform() | |
+ http_responses = self.http01.perform() | |
- self.assertEqual(len(sni_responses), 4) | |
+ self.assertEqual(len(http_responses), 4) | |
for i in six.moves.range(4): | |
- self.assertEqual(sni_responses[i], acme_responses[i]) | |
+ self.assertEqual(http_responses[i], acme_responses[i]) | |
def test_mod_config(self): | |
self.http01.add_chall(self.achalls[0]) | |
diff --git a/certbot-nginx/docs/api/tls_sni_01.rst b/certbot-nginx/docs/api/tls_sni_01.rst | |
deleted file mode 100644 | |
index 5074f63d9..000000000 | |
--- a/certbot-nginx/docs/api/tls_sni_01.rst | |
+++ /dev/null | |
@@ -1,5 +0,0 @@ | |
-:mod:`certbot_nginx.tls_sni_01` | |
------------------------------------ | |
- | |
-.. automodule:: certbot_nginx.tls_sni_01 | |
- :members: | |
diff --git a/certbot-nginx/setup.py b/certbot-nginx/setup.py | |
index 9c69a53e4..b53e16659 100644 | |
--- a/certbot-nginx/setup.py | |
+++ b/certbot-nginx/setup.py | |
@@ -4,7 +4,7 @@ from setuptools.command.test import test as TestCommand | |
import sys | |
-version = '0.39.0' | |
+version = '0.40.0' | |
# Remember to update local-oldest-requirements.txt when changing the minimum | |
# acme/certbot version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment