- documentation on requirements for PRs
- see easybuilders/easybuild#350
- to complement http://easybuild.readthedocs.io/en/latest/Contributing.html#review-process-for-contributions
developbranch- Travis tests pass
- at least one successful test report (via
--upload-test-report) - comparison with existing easyconfigs via
eb --review-pr - style review (automated + visual by a human)
- don't merge your own PR (incl. @boegel!)
- also:
- how to set up Travis for your own forks
- use of GitHub reviews (approving PRs, requesting changes, etc.)
- support for
eb --merge-pr- already supported via
pr_check.py -M(https://github.com/boegel/eb-scripts), but should be integrated in EasyBuild framework - easybuilders/easybuild-framework#2266
- already supported via
- automatic style checking of PRs
- via
--check-stylesupport - also checking order of easyconfig parameter not strictly necessary?
- via
- move EasyBuild repositories to https://github.com/easybuilders
- easier to give 'outsiders' merge rights where needed
- criteria to be eligible for merge rights?
- see easybuilders/easybuild#350
- frequent contributor, sufficiently familiar with procedure
- active in EasyBuild community (IRC, Slack, ML)
- has system available to submit test reports for contributions
- candidates: @vanzod, @verdurin, @pescobar, @wpoely86, @migueldiascosta, @damianam
-
-
Save boegel/315385ae425268cb75ec583f451da88b to your computer and use it in GitHub Desktop.
checklist to enable getting help with easyconfig PRs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
@boegel, I would add two things:
Criteria to be eligible: Minimum amount of time involved in EB (since he/she started using it and being involved in the community). The idea behind is to try to ensure that people are familiar with possible historical quirks and issues.
Check for possible software collisions, e.g: python at
GCCcorevs top level. I think it is important to minimize the chances of collisions across all the levels in the hierarchy.