Skip to content

Instantly share code, notes, and snippets.

@bradgreens

bradgreens/ts-js-fucking-dece-ass-pull-requests.md

Last active October 19, 2021 18:29
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save bradgreens/67bd4b2735dcbde64afb56274bc6c3aa to your computer and use it in GitHub Desktop.
Save bradgreens/67bd4b2735dcbde64afb56274bc6c3aa to your computer and use it in GitHub Desktop.
Download ZIP
Raw
ts-js-fucking-dece-ass-pull-requests.md

Dece Pull Requests (for TS/JS)

Prior to opening your pull request, try not to suck.

If you are seeking review/feedback before meeting this criteria, meet as much as you can and TAP a DRAFT PR.

  • Remove unecessary debugging, Ctrl+F for debugger and console.log, remove unecessary noise
  • Review & improve comments, Ctrl+F for // and /**, pretend you're not you and see if they make sense
  • TS/JS Lint passes
  • TS/JS Tests pass
  • Optionally run the build locally
  • DRY blah blah, but don't overdo it, review may help with DRY/refactoring
  • Check if scope changed too much, if so, consider breaking up
  • At this point, write meaningful line items in the PR for the code & UI changes made
  • Try to wait until CI is green before opening
  • Expect to get wrecked anyways
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment