Skip to content

Instantly share code, notes, and snippets.

@brandonmanke

brandonmanke/express_session_submission.md

Created February 24, 2019 17:02
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save brandonmanke/c2dd98bf66483ad7e3427094588e42af to your computer and use it in GitHub Desktop.
Save brandonmanke/c2dd98bf66483ad7e3427094588e42af to your computer and use it in GitHub Desktop.
Download ZIP
Hack Illinois 2019 Submission
Raw
express_session_submission.md

I decided to work on the ExpressJS Session project because it was something that I have used countless times as a backend developer. This issue related to this contribution was expressjs/session#607. This issue is essentially a request to add Promise support to the sessionStore object.

The solution to this was particularly interesting as we had to maintain backwards compatibility with older Node versions (> 0.8.x).

Here is the current PR link: expressjs/session#635. This the tests for this PR are passing, however the coverage and test scope need to be improved for some of the methods (reload & destroy).

I technically worked alone on this project. However, not without the help of our mentor for the ExpressJS project.

It was really awesome to be able to contribute to something that you use regularly. I have gained a new appreciation for Open-Source Projects and everyone who has contributed to them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment