Skip to content

Instantly share code, notes, and snippets.

@brennanholtzclaw
Created May 13, 2016 21:38
Show Gist options
  • Save brennanholtzclaw/3944b226d3fc86cf409862284197d1f8 to your computer and use it in GitHub Desktop.
Save brennanholtzclaw/3944b226d3fc86cf409862284197d1f8 to your computer and use it in GitHub Desktop.

##Leap My code

  • Responder 1 This code is actually just wrong for fulfilling the test suite. I'm not sure why it's pushed up (says the guy that apparently pushed comments up).
  • Responder 2 Fortunately, this person also pushed up comments, so I don't feel quite so bad. They've used variables to meet certain qualifications which assigns them to either true or false. It seems odd to set the variable, and then return it later when you could just evaluate a boolean and return that response, cutting out a step.
  • Responder 3 This code is actually from a classmate. I don't really like using an or operator in an if statement's evaluation.
  • Responder 4 This code uses nested if statements which I really hate having to use. I am not a fan of this implimentation.
  • Responder 5 This is using some ES6 syntax. Neat!

##Hamming My code

  • Responder 1 Again, a fellow classmate's code. We basically have same code, except that he has used forEach where I built a for-loop.
  • Responder 2 This person also uses a for loop which makes me feel much better about my decision.
  • Responder 3 Another for-loop. I've only been coding in JS for a couple weeks, and already I see how important syntax and convention can be to reading code. This code is quite similar to mine, but hard to read.
  • Responder 4 Another for loop - though I'm noticing that I'm setting variables at the top of the code. No one else is. Maybe I don't 100% understand what that does.
  • Responder 5 Changing it up slightly, this code is implemented with a while loop. It appears to have totally different syntax from the for-loop.

##RNA Transcription http://exercism.io/submissions/0370741f6ad04743afa11eda0ab88e93

  • Responder 1 I wondered how best to implement something like this. The person has set a variable to equal a has of the nucleotide pairs. Then you just have to provide a key to be returned a value.
  • Responder 2 I didn't actually know there were case statements in JavaScript.
  • Responder 3 Ooof a case statement inside an if statement. I am starting to hate my if statement, but it's better than this.
  • Responder 4 This is a replacing function within the transcription function that creates an object and accesses it in the return line all at once. Pretty cool. Not totally sure what's going on in line 8 though.
  • Responder 5 This person added to the total string the result from an if/else statement to match the complements. I think combining the setting of complements with the action of the transcription is interesting, but I still prefer use of an object to make the logic clearer and avoid long if/elses.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment