Skip to content

Instantly share code, notes, and snippets.

@brennovich

brennovich/code-review-tips.md

Created December 7, 2018 15:47
Show Gist options
  • Star 1 You must be signed in to star a gist
  • Fork 1 You must be signed in to fork a gist
  • Save brennovich/1802ab70c55243cba6f5869af0cd3c6c to your computer and use it in GitHub Desktop.
Save brennovich/1802ab70c55243cba6f5869af0cd3c6c to your computer and use it in GitHub Desktop.
Download ZIP
Raw
code-review-tips.md
  • Make sure you are aware of the problem/feature.
  • Don't be rude, be polite.
  • Give suggestions and make clear why do you think you suggestion is better than the current approach.
  • Don't point out just the bad things, tell about what do you think is great as well.
  • Make it part of your daily workflow. (use github notifications)
  • http://www.dein.fr/2015-02-18-maslows-pyramid-of-code-review.html

pyramid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment