Skip to content

Instantly share code, notes, and snippets.

@briandant

briandant/imagepulling.md

Last active July 1, 2016 22:56
Show Gist options
  • Save briandant/bb2ecc9b7355d245c1ad31f7201e2bf1 to your computer and use it in GitHub Desktop.
Save briandant/bb2ecc9b7355d245c1ad31f7201e2bf1 to your computer and use it in GitHub Desktop.
Download ZIP
Raw
imagepulling.md

Image Pull Request PR Notes

My first one seems to have failed ... what would I do next as a user?

The PR will presumably sit in the "Recent" window, and I can't get rid of it.

A request to make a project can 500 if there's no image_settings associated:

Traceback

This may have happened because I tried to start a container from an image that was pulled directly (instead of via the Wharf PR button). However, this still seems to be an issue: why does the DB have images with no settings? If we're going to allow null we should do some validation somewhere elso to catch this error. Or maybe we could use the Default Image Settings by default?

@briandant
Copy link
Author

This feature is really only going to be used by Lee / Stuart, so if there's some small issues—like these—we'll be okay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment