POC

gistfile1.txt

// SPDX-License-Identifier: MIT
pragma solidity 0.8.9;

import {PreciseMathUtils} from "../../contracts/libraries/PreciseMathUtils.sol";
import {MathUtils} from "../../contracts/libraries/MathUtils.sol";
import "forge-std/Test.sol";
import {console} from "forge-std/console.sol";
import "@openzeppelin/contracts/utils/math/SafeMath.sol";

// forge install forge-std/forge-std 
// Put this in src/test
// forge test --match-contract POC -vvvv
contract POC is Test {
    using SafeMath for uint256;
    // Set the treasuryRewardCutRate to 10% according to LIP-92.
    uint256 treasuryRewardCutRate = 100000000000000000000000000;

    function setUp() public {}

    // Current implementation of updateTranscoderWithFees
    function test_updateTranscoderWithFeesOld() public {
        // Let's say rewards is 10
        uint256 rewards = 10;

        // This should calculate to 10% of 10, resulting in 1.
        uint256 treasuryRewards = MathUtils.percOf(rewards, treasuryRewardCutRate);
        // As you can see in the console.log, the usage of MathUtils results in: 100000000000000000000
        console.log("treasuryRewards is: %s", treasuryRewards);

        // This will revert because 10 minus 100000000000000000000 will underflow.
        vm.expectRevert();
        rewards = rewards.sub(treasuryRewards);
    }

    // Correct implementation of updateTranscoderWithFees
    function test_updateTranscoderWithFeesWithFixed() public {
        // Let's say rewards is 10
        uint256 rewards = 10;

        // This should calculate to 10% of 10, resulting in 1.
        uint256 treasuryRewards = PreciseMathUtils.percOf(rewards, treasuryRewardCutRate);
        // As you can see in the console.log, the usage of PreciseMathUtils results in: 1
        console.log("treasuryRewards is: %s", treasuryRewards);

        rewards = rewards.sub(treasuryRewards);
        // treasuryRewards should be 10% of 10 -> 1
        assertEq(treasuryRewards, 1);
    }
}

nice