Skip to content

Instantly share code, notes, and snippets.

@buritica

buritica/pr.md

Last active August 29, 2015 13:57
Show Gist options
  • Star 1 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save buritica/9809807 to your computer and use it in GitHub Desktop.
Save buritica/9809807 to your computer and use it in GitHub Desktop.
Download ZIP
PR Template
Raw
pr.md

What's this PR do?

Where should the reviewer start?

How should this be manually tested?

Any background context you want to provide?

What are the relevant tickets?

Screenshots (if appropriate)

Questions:

  • Does the knowledge base need an update?

Dependencies

  • PRs
  • Releases
  • NPM
  • Bower
@felixlaumon
Copy link

@buritica This looks good to me! Not exactly related to PR template. But what do you think about whether to squash every commit into one before PR?

I feel like it could create nicer history in some cases, but it might make it harder to track down why a change is made (git blame) or hunting down a regression (git bisect)?

@bkempe
Copy link

bkempe commented Mar 27, 2014

Squash works if nobody else has branched off that branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment