Created
December 28, 2020 08:19
-
-
Save c80609a/021846470dacbb9d152746954ccc65ae to your computer and use it in GitHub Desktop.
pull_request.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have a policy of not adding new methods to Ruby | |
core classes unless it would benefit the framework | |
implementation or the large majority of | |
applications. For most cases I believe the required | |
keyword arguments are enough. This is actually the | |
case for assert_valid_keys as well since we can | |
change most calls to this method to keyword | |
arguments. To introduce this to 6.2 we need to show | |
that this would be useful for the framework, and | |
only two places don't are not enough. If you want | |
to investigate where we could use this method in | |
the framework it would help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment