refactor_1.php

<?php

// Refactor the following functions using your new skills from 99-bottles.
// Sorry about the lack of tests - bonus points if you write tests to get started.

function getStartDate() {
  return preg_match("/^\d\d\d\d-\d\d-\d\d$/", $_GET['dStartDate'])	? $_GET['dStartDate']	: date("Y-m-d", time() - 60 * 60 * 24 * 7);
}

function getEndDate() {
  return preg_match("/^\d\d\d\d-\d\d-\d\d$/", $_GET['dEndDate'])	? $_GET['dEndDate']		: date("Y-m-d");
}

// The code started as the following variables, but in the spirit of creating 
// testable seams I converted the variables to function calls.

$dStartDate	= preg_match("/^\d\d\d\d-\d\d-\d\d$/", $_GET['dStartDate'])	? $_GET['dStartDate']	: date("Y-m-d", time() - 60 * 60 * 24 * 7);
$dEndDate	= preg_match("/^\d\d\d\d-\d\d-\d\d$/", $_GET['dEndDate'])	? $_GET['dEndDate']		: date("Y-m-d");