Advanced Node and Express - Implementation of Social Authentication III

auth.js

const passport = require('passport');
const LocalStrategy = require('passport-local');
const bcrypt = require('bcrypt');
const ObjectID = require('mongodb').ObjectID;
const GitHubStrategy = require('passport-github').Strategy;

module.exports = function (app, myDataBase) {
  passport.serializeUser((user, done) => {
    done(null, user._id);
  });
  passport.deserializeUser((id, done) => {
    myDataBase.findOne({ _id: new ObjectID(id) }, (err, doc) => {
      if (err) return console.error(err);
      done(null, doc);
    });
  });
  passport.use(new LocalStrategy(
    function (username, password, done) {
      myDataBase.findOne({ username: username }, function (err, user) {
        console.log('User ' + username + ' attempted to log in.');
        if (err) { return done(err); }
        if (!user) { return done(null, false); }
        if (!bcrypt.compareSync(password, user.password)) { return done(null, false); }
        return done(null, user);
      });
    }
  ));

  passport.use(new GitHubStrategy({
      clientID: process.env.GITHUB_CLIENT_ID,
      clientSecret: process.env.GITHUB_CLIENT_SECRET,
      callbackURL: 'https://boilerplate-advancednode.your-username.repl.co/auth/github/callback'
    },
    function (accessToken, refreshToken, profile, cb) {
      console.log(profile);
      myDataBase.findAndModify(
        { id: profile.id },
        {},
        {
          $setOnInsert: {
            id: profile.id,
            name: profile.displayName || 'John Doe',
            photo: profile.photos[0].value || '',
            email: Array.isArray(profile.emails) ? profile.emails[0].value : 'No public email',
            created_on: new Date(),
            provider: profile.provider || ''
          },
          $set: {
            last_login: new Date()
          },
          $inc: {
            login_count: 1
          }
        },
        { upsert: true, new: true },
        (err, doc) => {
          return cb(null, doc.value);
        }
      );
    }
  ));
};

Hello, I think maybe we should use :
const GitHubStrategy = require('passport-github2').Strategy;

because if we refer to the documentation here : https://www.passportjs.org/packages/passport-github2/
The author of Passport-Github has not maintained the original module for a long time. Features in his module don't work since Github upgraded their API to version 3.0. We forked it and re-published it to NPM with a new name passport-github2.

but even when I use :
const GitHubStrategy = require('passport-github').Strategy;
this is working so I guess it's fine.

So for
const GitHubStrategy = require('passport-github2').Strategy;
or
const GitHubStrategy = require('passport-github').Strategy;
I'm not sur about wich one we should really use.

also since https://www.freecodecamp.org/learn/quality-assurance/advanced-node-and-express/how-to-put-a-profile-together
people certainly put that on them profile.pug
h2.center#welcome Welcome, #{username}!
so I guess it's will be better if inside the passport.use(new GitHubStrategy({ if we use

          $setOnInsert: {
            id: profile.id,
            username: profile.username,
            name: profile.displayName || 'John Doe',
            photo: profile.photos[0].value || '',
            email: Array.isArray(profile.emails) ? profile.emails[0].value : 'No public email',
            created_on: new Date(),
            provider: profile.provider || ''
          },

So that we have the username from github and then the username will be display on the profile page when we log in using github

Also I think this is important to explain inside the curriculum that if we want to use

  cookie: { secure: true }

with replit we should use also :

app.set('trust proxy', 1);
app.use(session({
  secret: process.env['SESSION_SECRET'],
  resave: true,
  saveUninitialized: true,
  cookie: { secure: true }
}));
app.use(passport.initialize());
app.use(passport.session());

and specify that : app.set('trust proxy', 1); is required because we are on replit so with a proxy but if we don't have proxy we should not use this option.
Source :

• https://stackoverflow.com/questions/36137873/using-app-set-to-set-trust-proxy
• https://stackoverflow.com/questions/39930070/nodejs-express-why-should-i-use-app-enabletrust-proxy
• https://stackoverflow.com/questions/44039069/express-session-secure-cookies-not-working