Created
March 4, 2011 17:49
-
-
Save cburgdorf/855371 to your computer and use it in GitHub Desktop.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
//Consider this as part of a bigger classlike object | |
.bind('NewButtonClicked.BaseEditWidget.FahrerController', function (event, data) { | |
if (isInEditMode()) { | |
dialogWidget.question('Änderungen verwerfen?', 'Sie befinden sich im Bearbeitungsmodus. Möchten Sie den Bearbeitungsmodus beenden und ggf. getätigte Änderungen verwerfen?').done(function () { | |
//This code is duplicate because I dont want to clutter my class like object with too many | |
//tiny trivial methods. However, wrapping the snippet in a function just inside this handler | |
//should be fine or not? (Look at the refactoring at the bottom) | |
currentEntity = createNewEntity(); | |
fahrerEditWidget.loadFahrer(currentEntity); | |
fahrerEditWidget.enable(); | |
}); | |
} else { | |
currentEntity = createNewEntity(); | |
fahrerEditWidget.loadFahrer(currentEntity); | |
fahrerEditWidget.enable(); | |
} | |
}); | |
//Refactoring | |
.bind('NewButtonClicked.BaseEditWidget.FahrerController', function (event, data) { | |
var createNewAndLoad = function () { | |
currentEntity = createNewEntity(); | |
fahrerEditWidget.loadFahrer(currentEntity); | |
fahrerEditWidget.enable(); | |
}; | |
if (isInEditMode()) { | |
dialogWidget.question('Änderungen verwerfen?', 'Sie befinden sich im Bearbeitungsmodus. Möchten Sie den Bearbeitungsmodus beenden und ggf. getätigte Änderungen verwerfen?').done(function () { | |
createNewAndLoad(); | |
}); | |
} else { | |
createNewAndLoad(); | |
} | |
}); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment