Skip to content

Instantly share code, notes, and snippets.

@cdecker
Created April 3, 2019 20:31
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save cdecker/9f7ebfe609e6a0507321625f12d37b64 to your computer and use it in GitHub Desktop.
Save cdecker/9f7ebfe609e6a0507321625f12d37b64 to your computer and use it in GitHub Desktop.
1: 19293ff5 = 1: 0c8b8f0f wally: Add wally_tx in bitcoin_tx
2: 3c930b0a = 2: 218d999f wally: Migrate version and locktime to libwally tx
3: 29fc7a0b = 3: af76a660 wally: Add shims to generate both transaction versions in parallel
4: e6a4c245 ! 4: da428425 tx: Change permute_{inputs,outputs} to sort both old and new txs
@@ -10,7 +10,7 @@
--- a/channeld/commit_tx.c
+++ b/channeld/commit_tx.c
@@
- * 7. Sort the outputs into [BIP 69
+ * 7. Sort the outputs into [BIP 69+CLTV
* order](#transaction-input-and-output-ordering)
*/
- permute_outputs(tx->output, cltvs, (const void **)*htlcmap);
@@ -54,7 +54,7 @@
--- a/common/initial_commit_tx.c
+++ b/common/initial_commit_tx.c
@@
- * 7. Sort the outputs into [BIP 69
+ * 7. Sort the outputs into [BIP 69+CLTV
* order](#transaction-input-and-output-ordering)
*/
- permute_outputs(tx->output, NULL, NULL);
5: e35ec18b = 5: db03c94d wally: Migrate the funding transaction to use the shims
6: 11fd96eb = 6: 021ae55c wally: Add a consistency check for old and new style txs
7: 836a9c3e = 7: ee1813dc wally: Migrate the funding transaction
8: 1507228c = 8: 0cc6bade wally: Migrate the withdraw transaction
9: 9217e97f = 9: 4df56944 wally: Migrate initial_commit_tx
10: bab42ecf = 10: 9ae07b53 wally: Migrate commit_tx
11: b340fdb3 = 11: 3ec152a3 wally: Migrate close_tx
12: 19ed40a8 = 12: 2add0dd0 wally: Build wally transactions in parallel with the old ones
13: c2d9cda7 = 13: 58e577bd wally: Migrate htlc_tx
14: 47705a78 = 14: 06b2464b wally: Add setters for output amounts, input witnesses and scripts
15: 9cec585c = 15: 51a8430c wally: Use output and input setters when signing / grinding feerate
16: 36a8d799 = 16: e3a09501 wally: Use input and output setters in onchaind and htlc_tx
17: 90c511e7 ! 17: 0ec38fa9 REMOVEME: Making extra sure that pulling a TX results in the correct read offset.
@@ -1,6 +1,6 @@
Author: Christian Decker <decker.christian@gmail.com>
- REMOVEME: Making extra sure that pulling a TX results in the correct read offset.
+ wally: Making extra sure that pulling a TX results in the correct read offset.
diff --git a/bitcoin/tx.c b/bitcoin/tx.c
--- a/bitcoin/tx.c
18: 052602ce = 18: d16c0652 wally: Migrate run-tx-encode to directly access the wally_tx
19: 8239ddc9 = 19: e34dce93 wally: Switch signatures over to using the wally_tx hash
20: c0cac481 = 20: 6dcdcebd wally: Move input amounts into a separate array
21: 9233dd90 = 21: 680bf584 wally: Use libwally only to serialize transactions
22: 79382fd7 = 22: 8867842e wally: Remove unused sha256_tx_for_sig function
23: a0aa41dd = 23: fcd93f13 wally: Migrate permute_tx to be wally_tx first
24: 3aee3bea = 24: 09b310fd wally: Add accessor methods for script and amount
25: 920002d8 = 25: b0e75e1f wally: Migrate onchaind to use the wally tx and the helpers
26: 7b6480c3 = 26: 81f8dd6b wally: Migrate hsmd to use the wally tx
27: ac0748f6 = 27: c969cfdb wally: Migrate main daemon to use wally transactions
28: 3435aa56 = 28: 6370f758 wally: Migrate channeld over to use libwally
29: cdfe2f94 = 29: ee5f2bbe wally: Remove tx->input and tx->output, wally all the way!
30: f72173df = 30: 74562cab wally: Post-migration cleanups
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment