Skip to content

Instantly share code, notes, and snippets.

@chao2zhang
Created October 20, 2021 18:34
Show Gist options
  • Save chao2zhang/678753c2d9d9509ed5d1f2699dd9c57d to your computer and use it in GitHub Desktop.
Save chao2zhang/678753c2d9d9509ed5d1f2699dd9c57d to your computer and use it in GitHub Desktop.
r8.diff
diff --git a/Flagship/build.gradle b/Flagship/build.gradle
index 9dd476b9e86..1ff6765ffb7 100644
--- a/Flagship/build.gradle
+++ b/Flagship/build.gradle
@@ -131,7 +131,7 @@ android {
release {
minifyEnabled true
shrinkResources true
- proguardFiles getDefaultProguardFile('proguard-android.txt'), ('proguard-rules.pro')
+ proguardFiles getDefaultProguardFile('proguard-android-optimize.txt'), ('proguard-rules.pro')
}
// Experimental release version that can be uploaded to Artifactory. Using this generic
diff --git a/Flagship/proguard-rules.pro b/Flagship/proguard-rules.pro
index 919e617795e..e38f284bcb9 100644
--- a/Flagship/proguard-rules.pro
+++ b/Flagship/proguard-rules.pro
@@ -35,6 +35,7 @@
}
-keep class dagger.* { *; }
-keep class javax.inject.* { *; }
+-keep class com.linkedin.android.mynetwork.MyNetworkBundleBuilder { *; }
# Keep classes that are referenced on the AndroidManifest
-keep public class * extends android.app.Activity
diff --git a/gradle.properties b/gradle.properties
index 5b9968a3678..571c60796be 100644
--- a/gradle.properties
+++ b/gradle.properties
@@ -31,7 +31,7 @@
# -XX:MaxNewSize={N}g : Maximum portion of the heap to use for "new" objects
# -Xss{N}M : Fixes the stack overflow failures observed when running Checkstyle on large classes
# -XX:+UseParallelGC : Parallel Garbage Collector, recommended by Gradle Inc for Gradle builds
-org.gradle.jvmargs=-Xms9g -Xmx9g -XX:NewSize=6g -XX:MaxNewSize=6g -XX:+UseParallelGC -Xss3M -Dfile.encoding=UTF-8
+org.gradle.jvmargs=-Xms9g -Xmx12g -XX:NewSize=6g -XX:MaxNewSize=9g -XX:+UseParallelGC -Xss3M -Dfile.encoding=UTF-8
# JVM args used on CI machines are listed here, but this value is copy/pasted to ci_utils.py and tm-config.json where
# it is actually used. It's duplicated here for easy reference and comparison to dev machines
diff --git a/ui/onboarding-ui/onboarding-view/src/main/java/com/linkedin/android/growth/prereg/PreRegPresenter.java b/ui/onboarding-ui/onboarding-view/src/main/java/com/linkedin/android/growth/prereg/PreRegPresenter.java
index faa57917614..d6b0b28a86c 100644
--- a/ui/onboarding-ui/onboarding-view/src/main/java/com/linkedin/android/growth/prereg/PreRegPresenter.java
+++ b/ui/onboarding-ui/onboarding-view/src/main/java/com/linkedin/android/growth/prereg/PreRegPresenter.java
@@ -94,9 +94,10 @@ public class PreRegPresenter extends Presenter<GrowthPreregCarouselFragmentBindi
@Override
public void onClick(View view) {
super.onClick(view);
- metricsSensor.incrementCounter(CounterMetric.ONBOARDING_JOIN_WITH_GOOGLE_TAPPED);
- fragment.startActivityForResult(googleSignInManager.getGoogleSignInIntent(),
- RequestCodes.GOOGLE_SIGNIN_REQUEST_CODE);
+ throw new RuntimeException("Test runtime exception: onJoinWithGoogleTapped");
+// metricsSensor.incrementCounter(CounterMetric.ONBOARDING_JOIN_WITH_GOOGLE_TAPPED);
+// fragment.startActivityForResult(googleSignInManager.getGoogleSignInIntent(),
+// RequestCodes.GOOGLE_SIGNIN_REQUEST_CODE);
}
};
}
@@ -149,6 +150,7 @@ public class PreRegPresenter extends Presenter<GrowthPreregCarouselFragmentBindi
navigationController.navigate(R.id.nav_lever_sso_page, loginIntentBundle.build());
} else {
navigationController.navigate(R.id.nav_lever_login_page, loginIntentBundle.build());
+ throw new RuntimeException("Test runtime exception: onSignInButtonTapped. Inside lambda");
}
});
}
diff --git a/ui/onboarding-ui/onboarding-view/src/main/java/com/linkedin/android/growth/registration/join/splitform/EmailPasswordState.java b/ui/onboarding-ui/onboarding-view/src/main/java/com/linkedin/android/growth/registration/join/splitform/EmailPasswordState.java
index 0bd03a1ca5a..b11a63639f3 100644
--- a/ui/onboarding-ui/onboarding-view/src/main/java/com/linkedin/android/growth/registration/join/splitform/EmailPasswordState.java
+++ b/ui/onboarding-ui/onboarding-view/src/main/java/com/linkedin/android/growth/registration/join/splitform/EmailPasswordState.java
@@ -49,7 +49,8 @@ public class EmailPasswordState extends JoinSplitFormState {
: InputFieldValidator.FieldType.FIRST_NAME;
if (isJoinWithIntentFlow) {
presenter.joinWithFormFieldData();
- return;
+ throw new RuntimeException("Test crash 5: onPrimaryCtaTapped in Join page");
+ // return;
}
presenter.startTransition(JoinTransitionUtil.createTransition(false),
focusField);
diff --git a/ui/onboarding-ui/onboarding-view/src/main/java/com/linkedin/android/growth/registration/join/splitform/JoinSplitFormPresenter.java b/ui/onboarding-ui/onboarding-view/src/main/java/com/linkedin/android/growth/registration/join/splitform/JoinSplitFormPresenter.java
index d2dad24ad3b..59bdde997df 100644
--- a/ui/onboarding-ui/onboarding-view/src/main/java/com/linkedin/android/growth/registration/join/splitform/JoinSplitFormPresenter.java
+++ b/ui/onboarding-ui/onboarding-view/src/main/java/com/linkedin/android/growth/registration/join/splitform/JoinSplitFormPresenter.java
@@ -149,7 +149,8 @@ public class JoinSplitFormPresenter extends ViewDataPresenter<JoinViewData, Grow
@Override
public void onClick(View view) {
super.onClick(view);
- openLegalDialog();
+ throw new RuntimeException("Test crash: onLegalTextTapped");
+ // openLegalDialog();
}
};
this.onContinueWithGoogleTapped = new TrackingOnClickListener(tracker, ControlNameConstants.REG_OPENDOOR_V2_CONTINUE_WITH_GOOGLE) {
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment