Fun with PHP Arrays

gistfile1.php

// Given the following code

function foo(array $bar) {
  $barCount = count($bar);
  
  for ($i = 0; $i < $barCount; $i++) {
    $baz = explode(Validator::DELIMITER, $bar[$i]);
    unset($bar[$i]);
    
    foreach ($bar as $val) {
      $val = trim($val);
      if ($val !== '') {
        $bar[] = $val;
      }
    }
  }
  
  return $bar;
}

// What would have to be in $bar for it to trigger an
// "offset does not exist error" on the line with explode?

$bar = [
1 => "hello",
2 => "goodbye",
];

would trigger the problem.

A string key would blow this up:

$bar = ['hello' => 'world'];
count($bar); // 1
$bar[0]; // Blows up

$bar = [
"foo" => "trout"
];

would also trigger the problem.

Probably $bar is not continuously indexed like in

$bar = [0 => 'x', 2 => 'y'];

One reason could be, that for example array_unique() does not reset the point

http://3v4l.org/JsUIJ

$bar = [0 => 'x', 1 => 'y', 2 => 'y'];
$bar = array_unique($bar);
$bar[] = 'z';
var_dump($bar);

/*
array(3) {
  [0]=>
  string(1) "x"
  [1]=>
  string(1) "y"
  [3]=>
  string(1) "z"
}
*/

unset($bar[$i]);

I think this may be causing the problem; once you've unset an item in the array, $barCount is > than the actual number of items in the array, no?

use a foreach on the outer loop? unsetting inside a foreach is safe (IIRC)

Yeah I also think foreach would solve it.