Skip to content

Instantly share code, notes, and snippets.

@chasingSublimity
Created February 14, 2017 19:19
Show Gist options
  • Save chasingSublimity/6a1679bf53e59915a26bba4868ef469a to your computer and use it in GitHub Desktop.
Save chasingSublimity/6a1679bf53e59915a26bba4868ef469a to your computer and use it in GitHub Desktop.
capstone-two-feedback
Code is well organized, but the variable names could be a little clearer.
Endpoints are built well.
Tests could be rearranged to mimic use cases of PUT requests to /setlist endpoint.
Instead of seeding database before each test, the tests could be arranged in such a way that items are added
and removed as a part the tests, and not programatically.
Loadtime is slow.
Design is not super aesthetically pleasing, but intuitive.
Drag-and-Drop is solid, if a little visually buggy.
The google docs-esque "save to DB on action" is solid, makes for a more seamless UI experience.
Delete functionality needs a confirmation stage.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment