Created
February 14, 2017 19:19
-
-
Save chasingSublimity/6a1679bf53e59915a26bba4868ef469a to your computer and use it in GitHub Desktop.
capstone-two-feedback
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code is well organized, but the variable names could be a little clearer. | |
Endpoints are built well. | |
Tests could be rearranged to mimic use cases of PUT requests to /setlist endpoint. | |
Instead of seeding database before each test, the tests could be arranged in such a way that items are added | |
and removed as a part the tests, and not programatically. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loadtime is slow. | |
Design is not super aesthetically pleasing, but intuitive. | |
Drag-and-Drop is solid, if a little visually buggy. | |
The google docs-esque "save to DB on action" is solid, makes for a more seamless UI experience. | |
Delete functionality needs a confirmation stage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment