chicgeek

Code Review

Peer review is a vital tool for ensuring quality in modern engineering communities. In addition to the more obvious outcomes of accuracy, consistency & good design, reviewing is an effective method of knowledge sharing on a project.

Inviqa's approach

• Everyone's code should be reviewed
  Regardless of seniority or size of the PR. The reviewing process should be second nature.
• Anyone can review code
  We actively encourage all team members to get involved and help. Even if you are more junior you will learn from the process and get a better understanding of the wider application you are working on.
• Take note of who is responsible for merging the code

chicgeek

Use data attributes as selectors

Where possible, you are encouraged to use data attributes as DOM selectors and to store data passed into templates. Using IDs, class selectors, and structure to interact with the DOM is more fragile as they are liable to change.

Additionally, data attributes use a '''key-value''' structure which can be useful for passing information from templates to Javascript. These attributes can have any type values (string, integer, object, etc) and will default to a boolean of true if no value is set.

Additional reading: MDN docs on data attributes and this issue raised on a Shopify repo.

Example

Using a class:

chicgeek

Keybase proof

I hereby claim:

• I am chicgeek on github.
• I am chicgeek (https://keybase.io/chicgeek) on keybase.
• I have a public key whose fingerprint is 646D 6F8D 574E 87A8 211E 46C9 225E AA2C E15F D257

To claim this, I am signing this object:

chicgeek

/*doc
---
title: Flexbox helpers
name: flex
category: Layout
---

Flexbox allow us to add classes to parent elements to influence the layout of its children.
For a brief guide on flexbox properties, see [A Complete Guide to Flexbox](https://css-tricks.com/snippets/css/a-guide-to-flexbox/) from CSS Tricks.

chicgeek

[data-global-action="moments"],
.DismissibleModule,
.trends,
.wtf-module,
.wtf-module.has-content,
.js-activity-generic,
.bird-topbar-etched,
.WhoToFollow,
.Footer,
[data-item-type="prompt"],

chicgeek

$('.somelocalselector iframe').removeAttr('height width').wrap('<div class="video"/>');


.video {
    position: relative;
    padding-bottom: 56.5%;
    margin-top: 2em;
}
.video iframe {
    position: absolute;

chicgeek

Keybase proof

I hereby claim:

• I am chicgeek on github.
• I am chicgeek (https://keybase.io/chicgeek) on keybase.
• I have a public key whose fingerprint is 0A09 1719 22A4 5DDA 8002 C383 394F 8991 FF08 4CD9

To claim this, I am signing this object:

chicgeek

<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" id="icons-speech-Layer_1" xml:space="preserve" height="48" viewBox="575 400 42 42" width="48" version="1.1" y="0px" x="0px" enable-background="new 0 0 1500 1000"><path clip-rule="evenodd" d="m590.48 406.04c8.396 0 15.201 5.065 15.201 11.313s-6.806 11.312-15.201 11.312c-0.948 0-1.876-0.065-2.776-0.188-0.026 0.016-9.198 3.514-9.198 3.514s3.004-5.465 3.014-5.498c-3.784-2.058-6.242-5.385-6.242-9.14 0-6.24 6.81-11.3 15.21-11.3z" fill-rule="evenodd"/><path clip-rule="evenodd" d="m603.53 409.57c9.943 9.905-1.768 20.459-11.313 20.459 0 0 1.062 2.166 9.457 2.166 0.948 0 1.875-0.065 2.775-0.188 0.026 0.015 9.198 3.513 9.198 3.513s-3.004-5.465-3.014-5.498c3.784-2.058 6.242-5.385 6.242-9.14-0.02-6.24-6.43-11.26-13.36-11.31z" fill-rule="evenodd"/><path d="m598.84 414.45l-8.843 8.843c-0.222 0.222-0.582 0.222-0.804 0l-0.178-0.178h-0.001l-0.193-0.194-0.834-0.834c-0.005-0.005-0.007-0.013-0.012-0.018l-3.825-3.853c-0.222-0.222-0.222-0.582 0-0.804

chicgeek

    <!--
    Customer account dashboard
-->
    <customer_account_index>
        <reference name="content">
            <block type="customer/account_dashboard" name="customer_account_dashboard" template="customer/account/dashboard.phtml">
                <block type="customer/account_dashboard_hello" name="customer_account_dashboard_hello" as="hello" template="customer/account/dashboard/hello.phtml"/>
                <block type="core/template" name="customer_account_dashboard_top" as="top" />