Skip to content

Instantly share code, notes, and snippets.

Avatar

Chinmay Garde chinmaygarde

  • Google
  • San Francisco, CA
View GitHub Profile
View hacky_fix.diff
diff --git a/shell/platform/darwin/ios/framework/Source/FlutterViewController.mm b/shell/platform/darwin/ios/framework/Source/FlutterViewController.mm
index bc8f4c457..ee1df602c 100644
--- a/shell/platform/darwin/ios/framework/Source/FlutterViewController.mm
+++ b/shell/platform/darwin/ios/framework/Source/FlutterViewController.mm
@@ -489,6 +489,11 @@ static void sendFakeTouchEvent(FlutterEngine* engine,
// NotifyCreated/NotifyDestroyed are synchronous and require hops between the UI and raster
// thread.
if (appeared) {
+ if ([UIApplication sharedApplication].applicationState != UIApplicationStateActive) {
+ NSLog(@"Attempted to call surface appeared while still in the background. Ignoring.");
View gist:dd179bb260bfe39aa180fc4d10ab3719
_AudioServicesPlaySystemSound
_CACurrentMediaTime
_CATransform3DConcat
_CATransform3DIdentity
_CATransform3DMakeScale
_CFAbsoluteTimeGetCurrent
_CFArrayAppendValue
_CFArrayApplyFunction
_CFArrayCreate
_CFArrayCreateMutable
@chinmaygarde
chinmaygarde / patch.diff
Created Sep 30, 2019
Platform Task Runner Renders as Well
View patch.diff
diff --git a/shell/platform/embedder/embedder_thread_host.cc b/shell/platform/embedder/embedder_thread_host.cc
index 5c2a1f3ae..e454bc76d 100644
--- a/shell/platform/embedder/embedder_thread_host.cc
+++ b/shell/platform/embedder/embedder_thread_host.cc
@@ -110,10 +110,10 @@ EmbedderThreadHost::CreateEmbedderManagedThreadHost(
flutter::TaskRunners task_runners(
kFlutterThreadName,
- platform_task_runner, // platform
- thread_host.gpu_thread->GetTaskRunner(), // gpu
View gist:0e467c8560b83c922fdbf07072c7e9d8
FAILED: dart-sdk/model/CIPD_VERSION.json dart-sdk/model/lexeme/idx2word.json dart-sdk/model/lexeme/word2idx.json dart-sdk/model/lexeme/model.tflite
python ../../third_party/dart/tools/copy_tree.py --from /Users/chinmaygarde/VersionControlled/engine/src/third_party/dart/pkg/analysis_server/language_model --to /Users/chinmaygarde/VersionControlled/engine/src/out/host_profile/dart-sdk/model
Traceback (most recent call last):
File "../../third_party/dart/tools/copy_tree.py", line 169, in <module>
sys.exit(Main(sys.argv))
File "../../third_party/dart/tools/copy_tree.py", line 160, in Main
CopyTree(args.copy_from, args.to)
File "../../third_party/dart/tools/copy_tree.py", line 107, in CopyTree
raise RuntimeError(msg)
RuntimeError: Some file copies failed:
@chinmaygarde
chinmaygarde / FlutterEngine.sublime-project
Last active Dec 17, 2021
FlutterEngine.sublime-project
View FlutterEngine.sublime-project
{
"build_systems": [
{
"name": "GN Build All",
"shell_cmd": "ninja -j999",
"working_dir": "${project_path}/out/host_debug_unopt",
"file_regex": "(.*):([\\d]+):([\\d]+)?:? ?((?:error|warning|note): ?.*)",
"shell": true,
}
],
View codec.cc
diff --git a/lib/ui/painting/codec.cc b/lib/ui/painting/codec.cc
index b181837e3..fc31f3f32 100644
--- a/lib/ui/painting/codec.cc
+++ b/lib/ui/painting/codec.cc
@@ -4,6 +4,8 @@
#include "flutter/lib/ui/painting/codec.h"
+#include <sys/mman.h>
+
View gist:d77a4ce77b9b4241f78496773a1ca382
diff --git a/tools/gn b/tools/gn
index 963e2f3f9..3905798ac 100755
--- a/tools/gn
+++ b/tools/gn
@@ -92,13 +92,18 @@ def to_gn_args(args):
gn_args['skia_use_expat'] = args.target_os == 'android'
gn_args['skia_use_fontconfig'] = args.enable_fontconfig
gn_args['flutter_use_fontconfig'] = args.enable_fontconfig
- gn_args['flutter_enable_skshaper'] = args.enable_skshaper
gn_args['is_official_build'] = True # Disable Skia test utilities.
View codec.diff
diff --git a/lib/ui/painting/image_decoder.cc b/lib/ui/painting/image_decoder.cc
index 98d06f669..db560b9fa 100644
--- a/lib/ui/painting/image_decoder.cc
+++ b/lib/ui/painting/image_decoder.cc
@@ -6,6 +6,7 @@
#include "flutter/fml/make_copyable.h"
#include "flutter/fml/trace_event.h"
+#include "third_party/skia/include/codec/SkCodec.h"
View gist:f0b6cc4924c4c09ac9dfe5dcf6e5d083
15:37:06  ...VersionControlled/engine/src   master ✘ ⬆ ✹  3m2s 
$ du -k out/ios_release_metal/Flutter.framework/Flutter
10632 out/ios_release_metal/Flutter.framework/Flutter
15:38:09  ...VersionControlled/engine/src   master ✘ ⬆ ✹ 
$ du -k out/ios_release/Flutter.framework/Flutter
10412 out/ios_release/Flutter.framework/Flutter
@chinmaygarde
chinmaygarde / error.txt
Last active Apr 25, 2019
Name Collision
View error.txt
/abspath/fuchsia/sdk/fidl/fuchsia.images/encoded_image.fidl:7:8: error: Name collision: EncodedImage
struct EncodedImage {
^