Skip to content

Instantly share code, notes, and snippets.

@christophrumpel

christophrumpel/pull-request-text-order.md

Created April 6, 2020 14:21
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save christophrumpel/7621833a9b260e00fafcda30feb50ae4 to your computer and use it in GitHub Desktop.
Save christophrumpel/7621833a9b260e00fafcda30feb50ae4 to your computer and use it in GitHub Desktop.
Download ZIP
Raw
pull-request-text-order.md

This PR solves the order bug when using command and other assertions in the same test.

Please find more detailed informion in the issue XX

Current State

Laravel command assertions (expectations) are being run before the application gets destroyes. This is why command assertions alwaysrun at the end of the test and not in the provided order inside the test.

Solution

This PR changes the implementation so that the command assertions run immediately after defining them. This will will fix the order bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment