Skip to content

Instantly share code, notes, and snippets.

@chydee
Forked from riggaroo/PULL_REQUEST_TEMPLATE
Created March 28, 2020 10:38
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save chydee/f361fb61264d6dfa18c4b41dfa78e4a0 to your computer and use it in GitHub Desktop.
Save chydee/f361fb61264d6dfa18c4b41dfa78e4a0 to your computer and use it in GitHub Desktop.
Pull request template format. Add this file to your .github folder
<!--- Provide a general summary of your changes in the Title above -->
<!--- If there is no changelog entry, label this PR as trivial to bypass the Danger warning -->
## Description
<!--- Describe your changes in detail -->
## Motivation and Context
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
## How Has This Been Tested?
<!--- Please describe in detail how you tested your changes. -->
<!--- Include details of your testing environment, and the tests you ran to -->
<!--- see how your change affects other areas of the code, etc. -->
## Screenshots / GIFs (if appropriate):
<!--- Bonus points for GIFS --->
## Analytics (if appropriate):
<!--- Are all the expected analytics events implemented? --->
- [ ] I have reviewed the [event taxonomy](removed)
- [ ] I have added any required analytics calls
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Enhancement (non-breaking change which cleans up / improves existing functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
## Checklist
<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->
<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->
- [ ] I have read the **CONTRIBUTING** document.
- [ ] I have added unit tests to code changes that make sense.
- [ ] I have considered the accessibility of my changes (i.e. did I add proper content descriptions to images, or run my changes with talkback enabled?)
## Resolves
<!-- List the issues that will be closed by this PR in the following format -->
<!-- resolves AN-123 -->
<!-- This will ensure that they are automatically closed once the PR is merged -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment