Skip to content

Instantly share code, notes, and snippets.

@conor-pwbot
Created November 29, 2022 18:47
Show Gist options
  • Save conor-pwbot/16db625a8943ccda22b2b0e2ab599b4d to your computer and use it in GitHub Desktop.
Save conor-pwbot/16db625a8943ccda22b2b0e2ab599b4d to your computer and use it in GitHub Desktop.
ERROR: Macros with complex values should be enclosed in parentheses
==========
checkpatch - FAILED
ERROR: Macros with complex values should be enclosed in parentheses
#43: FILE: arch/riscv/include/asm/alternative-macros.h:53:
+#define __ALTERNATIVE_CFG(...) ALTERNATIVE_CFG __VA_ARGS__
ERROR: Macros with complex values should be enclosed in parentheses
#44: FILE: arch/riscv/include/asm/alternative-macros.h:54:
+#define __ALTERNATIVE_CFG_2(...) ALTERNATIVE_CFG_2 __VA_ARGS__
ERROR: Macros with complex values should be enclosed in parentheses
#60: FILE: arch/riscv/include/asm/alternative-macros.h:96:
+#define __ALTERNATIVE_CFG_2(old_c, new_c_1, vendor_id_1, errata_id_1, enable_1, \
+ new_c_2, vendor_id_2, errata_id_2, enable_2) \
+ __ALTERNATIVE_CFG(old_c, new_c_1, vendor_id_1, errata_id_1, enable_1) \
ALT_NEW_CONTENT(vendor_id_2, errata_id_2, enable_2, new_c_2)
total: 3 errors, 0 warnings, 0 checks, 80 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
Commit 6756dbdbd66e ("riscv: Don't duplicate _ALTERNATIVE_CFG* macros") has style problems, please review.
NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment