desc

CHECK: Macro argument 'insn' may be better as '(insn)' to avoid precedence issues
CHECK: No space is necessary after a cast
ERROR: open brace '{' following function definitions go on the next line
WARNING: externs should be avoided in .c files

retcode

1

summary

==========
checkpatch - FAILED

CHECK: Macro argument 'insn' may be better as '(insn)' to avoid precedence issues
#161: FILE: arch/riscv/kernel/traps_misaligned.c:158:
+#define FP_GET_RD(insn)		(insn >> 7 & 0x1F)

WARNING: externs should be avoided in .c files
#163: FILE: arch/riscv/kernel/traps_misaligned.c:160:
+extern void put_f32_reg(unsigned long fp_reg, unsigned long value);

CHECK: No space is necessary after a cast
#184: FILE: arch/riscv/kernel/traps_misaligned.c:181:
+	value = (unsigned long) &val;

ERROR: open brace '{' following function definitions go on the next line
#241: FILE: arch/riscv/kernel/traps_misaligned.c:238:
+static void set_f32_rd(unsigned long insn, struct pt_regs *regs,
+		       unsigned long val) {}

total: 1 errors, 1 warnings, 2 checks, 313 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit 53e980961f7c ("riscv: add floating point insn support to misaligned access emulation") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.