Skip to content

Instantly share code, notes, and snippets.

@conor-pwbot
Created March 27, 2023 23:25
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save conor-pwbot/a53b6206c0553b37ec787a0e2ad731a4 to your computer and use it in GitHub Desktop.
Save conor-pwbot/a53b6206c0553b37ec787a0e2ad731a4 to your computer and use it in GitHub Desktop.
CHECK: extern prototypes should be avoided in .h files
ERROR: space required after that ',' (ctx:VxV)
WARNING: function definition argument 'const void *' should also have an identifier name
==========
checkpatch - FAILED
WARNING: function definition argument 'const void *' should also have an identifier name
#74: FILE: arch/arm/include/asm/cacheflush.h:130:
+ void (*dma_clean_range)(const void *, const void *);
WARNING: function definition argument 'const void *' should also have an identifier name
#74: FILE: arch/arm/include/asm/cacheflush.h:130:
+ void (*dma_clean_range)(const void *, const void *);
WARNING: function definition argument 'const void *' should also have an identifier name
#75: FILE: arch/arm/include/asm/cacheflush.h:131:
+ void (*dma_inv_range)(const void *, const void *);
WARNING: function definition argument 'const void *' should also have an identifier name
#75: FILE: arch/arm/include/asm/cacheflush.h:131:
+ void (*dma_inv_range)(const void *, const void *);
CHECK: extern prototypes should be avoided in .h files
#92: FILE: arch/arm/include/asm/cacheflush.h:178:
+extern void dmac_clean_range(const void *, const void *);
WARNING: function definition argument 'const void *' should also have an identifier name
#92: FILE: arch/arm/include/asm/cacheflush.h:178:
+extern void dmac_clean_range(const void *, const void *);
WARNING: function definition argument 'const void *' should also have an identifier name
#92: FILE: arch/arm/include/asm/cacheflush.h:178:
+extern void dmac_clean_range(const void *, const void *);
CHECK: extern prototypes should be avoided in .h files
#93: FILE: arch/arm/include/asm/cacheflush.h:179:
+extern void dmac_inv_range(const void *, const void *);
WARNING: function definition argument 'const void *' should also have an identifier name
#93: FILE: arch/arm/include/asm/cacheflush.h:179:
+extern void dmac_inv_range(const void *, const void *);
WARNING: function definition argument 'const void *' should also have an identifier name
#93: FILE: arch/arm/include/asm/cacheflush.h:179:
+extern void dmac_inv_range(const void *, const void *);
ERROR: space required after that ',' (ctx:VxV)
#114: FILE: arch/arm/include/asm/glue-cache.h:160:
+#define dmac_clean_range __glue(_CACHE,_dma_clean_range)
^
ERROR: space required after that ',' (ctx:VxV)
#115: FILE: arch/arm/include/asm/glue-cache.h:161:
+#define dmac_inv_range __glue(_CACHE,_dma_inv_range)
^
total: 2 errors, 8 warnings, 2 checks, 465 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
Commit d80f74fc988a ("ARM: dma-mapping: bring back dmac_{clean,inv}_range") has style problems, please review.
NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment