-
-
Save conor-pwbot/b67f3c14629178eb104d5c43bff0903f to your computer and use it in GitHub Desktop.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ERROR: Macros with complex values should be enclosed in parentheses | |
WARNING: Avoid unnecessary line continuations | |
WARNING: please, no spaces at the start of a line |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
========== | |
checkpatch - FAILED | |
WARNING: Avoid unnecessary line continuations | |
#23: FILE: arch/riscv/include/asm/alternative-macros.h:72: | |
+.macro __ALTERNATIVE_CFG_3 old_c, new_c_1, vendor_id_1, errata_id_1, enable_1, \ | |
ERROR: Macros with complex values should be enclosed in parentheses | |
#38: FILE: arch/riscv/include/asm/alternative-macros.h:87: | |
+#define _ALTERNATIVE_CFG_3(old_c, new_c_1, vendor_id_1, errata_id_1, \ | |
+ CONFIG_k_1, \ | |
+ new_c_2, vendor_id_2, errata_id_2, \ | |
+ CONFIG_k_2, \ | |
+ new_c_3, vendor_id_3, errata_id_3, \ | |
+ CONFIG_k_3) \ | |
+ __ALTERNATIVE_CFG_3 old_c, new_c_1, vendor_id_1, errata_id_1, \ | |
+ IS_ENABLED(CONFIG_k_1), \ | |
+ new_c_2, vendor_id_2, errata_id_2, \ | |
+ IS_ENABLED(CONFIG_k_2), \ | |
+ new_c_3, vendor_id_3, errata_id_3, \ | |
+ IS_ENABLED(CONFIG_k_3) | |
ERROR: Macros with complex values should be enclosed in parentheses | |
#95: FILE: arch/riscv/include/asm/alternative-macros.h:214: | |
+#define _ALTERNATIVE_CFG_3(old_c, new_c_1, vendor_id_1, errata_id_1, \ | |
+ CONFIG_k_1, \ | |
+ new_c_2, vendor_id_2, errata_id_2, \ | |
+ CONFIG_k_2, \ | |
+ new_c_3, vendor_id_3, errata_id_3, \ | |
+ CONFIG_k_3) \ | |
+ __ALTERNATIVE_CFG old_c | |
WARNING: please, no spaces at the start of a line | |
#101: FILE: arch/riscv/include/asm/alternative-macros.h:220: | |
+ __ALTERNATIVE_CFG old_c$ | |
WARNING: please, no spaces at the start of a line | |
#116: FILE: arch/riscv/include/asm/alternative-macros.h:242: | |
+ __ALTERNATIVE_CFG(old_c)$ | |
total: 2 errors, 3 warnings, 0 checks, 122 lines checked | |
NOTE: For some of the reported defects, checkpatch may be able to | |
mechanically convert to the typical style using --fix or --fix-inplace. | |
Commit 0705ae2ec019 ("riscv: asm: alternative-macros: Introduce ALTERNATIVE_3() macro") has style problems, please review. | |
NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF | |
NOTE: If any of the errors are false positives, please report | |
them to the maintainer, see CHECKPATCH in MAINTAINERS. | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment