desc

CHECK: Alignment should match open parenthesis
CHECK: Lines should not end with a '('
CHECK: Unnecessary parentheses around 'err_code == 0'
CHECK: spaces preferred around that '-' (ctx:VxV)
ERROR: space prohibited after that open parenthesis '('
ERROR: space prohibited before that close parenthesis ')'
WARNING: Statements should start on a tabstop

retcode

1

summary

==========
checkpatch - FAILED

CHECK: Alignment should match open parenthesis
#307: FILE: kernel/trace/fgraph.c:250:
+static unsigned long __ftrace_return_to_handler(unsigned long retval_1st,
+			unsigned long retval_2nd, unsigned long frame_pointer)

CHECK: Alignment should match open parenthesis
#325: FILE: kernel/trace/fgraph.c:281:
+unsigned long ftrace_return_to_handler(unsigned long retval_1st,
+			unsigned long retval_2nd, unsigned long frame_pointer)

CHECK: Alignment should match open parenthesis
#363: FILE: kernel/trace/trace_entries.h:92:
+FTRACE_ENTRY_PACKED(funcgraph_exit, ftrace_graph_ret_entry,
+

CHECK: Lines should not end with a '('
#366: FILE: kernel/trace/trace_entries.h:95:
+	F_STRUCT(

ERROR: space prohibited after that open parenthesis '('
#367: FILE: kernel/trace/trace_entries.h:96:
+		__field_struct(	struct ftrace_graph_ret,	ret	)

ERROR: space prohibited before that close parenthesis ')'
#367: FILE: kernel/trace/trace_entries.h:96:
+		__field_struct(	struct ftrace_graph_ret,	ret	)

ERROR: space prohibited after that open parenthesis '('
#368: FILE: kernel/trace/trace_entries.h:97:
+		__field_packed(	unsigned long,	ret,		func	)

ERROR: space prohibited before that close parenthesis ')'
#368: FILE: kernel/trace/trace_entries.h:97:
+		__field_packed(	unsigned long,	ret,		func	)

ERROR: space prohibited after that open parenthesis '('
#369: FILE: kernel/trace/trace_entries.h:98:
+		__field_packed(	unsigned long,	ret,		retval	)

ERROR: space prohibited before that close parenthesis ')'
#369: FILE: kernel/trace/trace_entries.h:98:
+		__field_packed(	unsigned long,	ret,		retval	)

ERROR: space prohibited after that open parenthesis '('
#370: FILE: kernel/trace/trace_entries.h:99:
+		__field_packed(	int,		ret,		depth	)

ERROR: space prohibited before that close parenthesis ')'
#370: FILE: kernel/trace/trace_entries.h:99:
+		__field_packed(	int,		ret,		depth	)

ERROR: space prohibited after that open parenthesis '('
#371: FILE: kernel/trace/trace_entries.h:100:
+		__field_packed(	unsigned int,	ret,		overrun	)

ERROR: space prohibited before that close parenthesis ')'
#371: FILE: kernel/trace/trace_entries.h:100:
+		__field_packed(	unsigned int,	ret,		overrun	)

ERROR: space prohibited after that open parenthesis '('
#372: FILE: kernel/trace/trace_entries.h:101:
+		__field_packed(	unsigned long long, ret,	calltime)

ERROR: space prohibited after that open parenthesis '('
#373: FILE: kernel/trace/trace_entries.h:102:
+		__field_packed(	unsigned long long, ret,	rettime	)

ERROR: space prohibited before that close parenthesis ')'
#373: FILE: kernel/trace/trace_entries.h:102:
+		__field_packed(	unsigned long long, ret,	rettime	)

CHECK: spaces preferred around that '-' (ctx:VxV)
#406: FILE: kernel/trace/trace_functions_graph.c:63:
+	{ TRACER_OPT(funcgraph-retval, TRACE_GRAPH_PRINT_RETVAL) },
 	                      ^

CHECK: Alignment should match open parenthesis
#422: FILE: kernel/trace/trace_functions_graph.c:633:
+static void print_graph_retval(struct trace_seq *s, unsigned long retval,
+				bool leaf, void *func, bool hex_format)

CHECK: Unnecessary parentheses around 'err_code == 0'
#444: FILE: kernel/trace/trace_functions_graph.c:655:
+		if (hex_format || (err_code == 0))

CHECK: Alignment should match open parenthesis
#446: FILE: kernel/trace/trace_functions_graph.c:657:
+			trace_seq_printf(s, "%ps(); /* = 0x%lx */\n",
+					func, retval);

CHECK: Alignment should match open parenthesis
#449: FILE: kernel/trace/trace_functions_graph.c:660:
+			trace_seq_printf(s, "%ps(); /* = %ld */\n",
+					func, err_code);

CHECK: Unnecessary parentheses around 'err_code == 0'
#451: FILE: kernel/trace/trace_functions_graph.c:662:
+		if (hex_format || (err_code == 0))

CHECK: Alignment should match open parenthesis
#453: FILE: kernel/trace/trace_functions_graph.c:664:
+			trace_seq_printf(s, "} /* %ps = 0x%lx */\n",
+					func, retval);

CHECK: Alignment should match open parenthesis
#456: FILE: kernel/trace/trace_functions_graph.c:667:
+			trace_seq_printf(s, "} /* %ps = %ld */\n",
+					func, err_code);

WARNING: Statements should start on a tabstop
#465: FILE: kernel/trace/trace_functions_graph.c:676:
+			  do {} while (0)

CHECK: Alignment should match open parenthesis
#483: FILE: kernel/trace/trace_functions_graph.c:730:
+		print_graph_retval(s, graph_ret->retval, true, (void *)call->func,
+				!!(flags & TRACE_GRAPH_PRINT_RETVAL_HEX));

CHECK: Alignment should match open parenthesis
#507: FILE: kernel/trace/trace_functions_graph.c:1016:
+		print_graph_retval(s, trace->retval, false, (void *)trace->func,
+			!!(flags & TRACE_GRAPH_PRINT_RETVAL_HEX));

total: 13 errors, 1 warnings, 14 checks, 348 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit 57e9b3883a1a ("function_graph: Support recording and printing the return value of function") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.