desc

CHECK: Alignment should match open parenthesis
CHECK: Please don't use multiple blank lines
ERROR: code indent should use tabs where possible
WARNING: Improper SPDX comment style for 'include/linux/dma-sync.h', please use '/*' instead
WARNING: Missing a blank line after declarations
WARNING: Missing or malformed SPDX-License-Identifier tag in line 1
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
WARNING: please, no spaces at the start of a line

retcode

1

summary

==========
checkpatch - FAILED

CHECK: Please don't use multiple blank lines
#242: FILE: arch/arm/mm/dma-mapping.c:696:
+
+

ERROR: code indent should use tabs where possible
#651: FILE: arch/mips/mm/dma-noncoherent.c:111:
+                    cpu_needs_post_dma_flush();$

WARNING: please, no spaces at the start of a line
#651: FILE: arch/mips/mm/dma-noncoherent.c:111:
+                    cpu_needs_post_dma_flush();$

ERROR: code indent should use tabs where possible
#659: FILE: arch/mips/mm/dma-noncoherent.c:118:
+               const struct iommu_ops *iommu, bool coherent)$

WARNING: please, no spaces at the start of a line
#659: FILE: arch/mips/mm/dma-noncoherent.c:118:
+               const struct iommu_ops *iommu, bool coherent)$

WARNING: please, no spaces at the start of a line
#662: FILE: arch/mips/mm/dma-noncoherent.c:120:
+       dev->dma_coherent = coherent;$

WARNING: Missing a blank line after declarations
#711: FILE: arch/nios2/mm/dma-mapping.c:35:
+	unsigned long vaddr = (unsigned long)phys_to_virt(paddr);
+	invalidate_dcache_range(vaddr, (unsigned long)(vaddr + size));

CHECK: Please don't use multiple blank lines
#1007: FILE: arch/riscv/mm/dma-noncoherent.c:48:
+
+

CHECK: Please don't use multiple blank lines
#1170: FILE: arch/xtensa/kernel/pci-dma.c:73:
+
+

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#1175: 
new file mode 100644

WARNING: Improper SPDX comment style for 'include/linux/dma-sync.h', please use '/*' instead
#1180: FILE: include/linux/dma-sync.h:1:
+// SPDX-License-Identifier: GPL-2.0

WARNING: Missing or malformed SPDX-License-Identifier tag in line 1
#1180: FILE: include/linux/dma-sync.h:1:
+// SPDX-License-Identifier: GPL-2.0

CHECK: Alignment should match open parenthesis
#1204: FILE: include/linux/dma-sync.h:25:
+void arch_sync_dma_for_device(phys_addr_t paddr, size_t size,
+		enum dma_data_direction dir)

WARNING: Missing a blank line after declarations
#1259: FILE: include/linux/dma-sync.h:80:
+		struct page *page = pfn_to_page(pfn++);
+		set_bit(PG_dcache_clean, &page->flags);

CHECK: Alignment should match open parenthesis
#1266: FILE: include/linux/dma-sync.h:87:
+void arch_sync_dma_for_cpu(phys_addr_t paddr, size_t size,
+		enum dma_data_direction dir)

total: 2 errors, 8 warnings, 5 checks, 1118 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

NOTE: Whitespace errors detected.
      You may wish to use scripts/cleanpatch or scripts/cleanfile

Commit acc85aab965e ("dma-mapping: replace custom code with generic implementation") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.