desc

ERROR: do not use assignment in if condition
WARNING: Comparisons should place the constant on the right side of the test
WARNING: Missing a blank line after declarations
WARNING: braces {} are not necessary for single statement blocks
WARNING: suspect code indent for conditional statements (8, 29)

retcode

1

summary

==========
checkpatch - FAILED

WARNING: suspect code indent for conditional statements (8, 29)
#78: FILE: drivers/firmware/efi/libstub/string.c:126:
+	for (sc = s; *sc != '\0'; ++sc)
+		/* nothing */;

WARNING: suspect code indent for conditional statements (8, 29)
#95: FILE: drivers/firmware/efi/libstub/string.c:143:
+	for (sc = s; count-- && *sc != '\0'; ++sc)
+		/* nothing */;

WARNING: Missing a blank line after declarations
#134: FILE: drivers/firmware/efi/libstub/string.c:182:
+	const char *last = NULL;
+	do {

WARNING: Missing a blank line after declarations
#160: FILE: drivers/firmware/efi/libstub/string.c:208:
+		const unsigned long *u2 = ct;
+		do {

WARNING: Comparisons should place the constant on the right side of the test
#171: FILE: drivers/firmware/efi/libstub/string.c:219:
+	for (su1 = cs, su2 = ct; 0 < count; ++su1, ++su2, count--)

ERROR: do not use assignment in if condition
#172: FILE: drivers/firmware/efi/libstub/string.c:220:
+		if ((res = *su1 - *su2) != 0)

WARNING: Missing a blank line after declarations
#192: FILE: drivers/firmware/efi/libstub/string.c:240:
+	const unsigned char *p = s;
+	while (n-- != 0) {

WARNING: braces {} are not necessary for single statement blocks
#193: FILE: drivers/firmware/efi/libstub/string.c:241:
+		if ((unsigned char)c == *p++) {
+			return (void *)(p - 1);
+		}

total: 1 errors, 7 warnings, 0 checks, 163 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit 211f80448f28 ("riscv: Fix EFI stub usage of KASAN instrumented string functions") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.