craig-davis

# Copy the latest hash to the clipboard
latest = log --pretty=format:'%H' -n1
h = !git latest && git latest | pbcopy

craig-davis

<?php
public function testAuthorHasPostsArray()
{
    self::assertIsArray(
        (new Author())->getPosts(),
        'Author should have an accessible array of posts'
    );
}

craig-davis

<?php
public function testAuthorHasPostsArray()
{
    $author = new Author();
    
    self::assertIsArray($author->getPosts());
}

craig-davis

<?php

class Post
{
    protected $sidebarTypes = [8, 11];

    protected $authorEditTimeout = 2592000;

    ...

craig-davis

@@ -7,8 +7,14 @@ class Post
         $isAuthor      = $this->getAuthorId() == $user->getId();
+        $isSupervisor  = $this->getRole() == 4;
+        $isSidebarPost = $this->getType() == 8;
         $isTooOld      = $this->created_at < time() — 2592000;

+        if ($isSupervisor && $isSidebarPost) {
+            return true;
+        }
+

craig-davis

<?php

class Post
{
    public function canEdit(User $user) : bool
    {
        $isEditor      = $user->getRole() == 3 && $this->getEditorId() == $user->getId();
        $isAdmin       = $user->getRole() > 5;
        $isAuthor      = $this->getAuthorId() == $user->getId();
        $isSupervisor  = $this->getRole() == 4;

craig-davis

<?php

class Post
{
    public function canEdit(User $user) : bool
    {
        $isEditor = $user->getRole() == 3 && $this->getEditorId() == $user->getId();
        $isAdmin  = $user->getRole() > 5;
        $isAuthor = $this->getAuthorId() == $user->getId();
        $isTooOld = $this->created_at < time() — 2592000;

craig-davis

<?php

class Post
{
    public function canEdit(User $user) : bool
    {
        $canEdit = false;
        if (($user->getRole() == 3 && $this->getEditorId() == $user->getId()) || $user->getRole() > 5 || ($this->getAuthorId() == $user->getId() && $this->created_at < time() — 2592000)) {
            $canEdit = true;
        }

craig-davis

<?php

function calculateSalePrice($item, $discount = 0) {
    if ($discount > 0) {
        return calculateDiscountedPrice($item->getPrice, $discount);
    }
    
    return $item->getPrice();
}

craig-davis

<?php

function calculateSalePrice($item, $discount = 0) {
    if ($discount == 0) {
        return $item->getPrice();
    }
    return calculateDiscountedPrice($item->getPrice, $discount);
}