Created
January 15, 2024 05:54
-
-
Save crashuniverse/53f71528b942eaf46d48edbcbe2e8ce5 to your computer and use it in GitHub Desktop.
purecode.ai assessment
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version 1 | |
Last updated Mon Jan 15, 2024 | |
// purecode.ai assessment | |
Good things | |
[TBD] | |
I mean, I don't have a great list here, not to say it is not great, I'd like to focus on the other list | |
first. | |
Challenges | |
1. When we use the first dropdown MUI, it is confusing as it highlights tailwind. Now this is critical | |
as I interacted with this UI first and if it doesn't instill a solid confidence, the overall | |
reputation slightly goes away instantly. | |
2. The dropdown UI framework is duplicated by another one when we scroll down to Doscover component. This | |
is not useful, is confusing and also takes away some space which could have been used for a very | |
important feature of sorting these components. | |
3. Continuing from above point, sorting alphabetically is important. This helps find the first component | |
say Login (or Signin) fast. Everyone has some usecase before they start hunting for it in the list. To | |
reduce feature bloat, we could just sort the list alphabetical instead of arbitrary. | |
4. Sometimes the example UI bleeds out of its boundary. Ex. https://purecode.ai/components/mui/Permission | |
This happens at several places (list not prepared yet) and this should be investigated why this happens. Once a fix exists, it would most probably solve several instances. The bounday of example apps | |
should be strict. | |
5. On login using github, it says Successful with GITHUB. This over emphasis may be avoided. Just | |
Successful with Github is cleaner. | |
6. I am logged in. Lets check Signin component. src/components/Signin/style.js has some weird code. Code | |
like this: pcClass7399550 : { is very unmaintainable. As in, no one would know what this code does, what it corresponds to. Unless I am extremely convinced that this is expected | |
(it may happen by a comment) this looks scary, wrong, and makes me doubtful as an intermediate | |
developer (novice ones would pass, because generated code). This is an important thing to have a open | |
discussion about. I'm still open to thoughts like maybe it is not too bad, but I haven't seen stuff like this. | |
7. Horizontal scrolls are not good. When we open too many tabs to see code, and we find the last tab | |
we scroll a bit to the right and the whole page scrolls to the right. Not cool. | |
8. Signin: Password fields are not asterisks. This sends an insight that the code generated (whatever | |
the means is) doesn't understand yet that the password field is different. I guess at this point I've | |
made my mind that I want to check as a prospective developer the login/signin component a little bit | |
deeper to see if this makes sense to use pure for more work. So this password field is an important aspect to be fixed. | |
... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment