MQL4: Calculate Profit or Loss on Trade

calcPL.mq4

/**
 * This method calculates the profit or loss of a position in the home currency of the account
 * @param  string  sym  
 * @param  int     type    0 = buy, 1 = sell
 * @param  double  entry
 * @param  double  exit
 * @param  double  lots
 * @result double          profit/loss in home currency
 */
 double calcPL(string sym, int type, double entry, double exit, double lots) {
   var result;
   if ( type == 0 ) {
     result = (exit - entry) * lots * (1 / MarketInfo(sym, MODE_POINT)) * MarketInfo(sym, MODE_TICKVALUE);
   } else if ( type == 1 ) {
     result = (entry - exit) * lots * (1 / MarketInfo(sym, MODE_POINT)) * MarketInfo(sym, MODE_TICKVALUE);
   }
   return ( result );

 }

No need for type check?
result = MathAbs((entry - exit)) * lots * (1 / MarketInfo(sym, MODE_POINT)) * MarketInfo(sym, MODE_TICKVALUE);

How about using buy and sell rather than entry exit so one does not need to specify whether its long or short?

double calcPL(string sym, double buy, double sell, double lots) { return (sell - buy) * lots .... }

for someone who likes to be shorter

double calcPL(string sym, int type, double entry, double exit, double lots) {
    double diff = ( type == 0 ) ? (exit - entry) : (entry - exit);
    double result = diff * lots * (1 / MarketInfo(sym, MODE_POINT)) * MarketInfo(sym, MODE_TICKVALUE);

    return NormalizeDouble(result, 2);
 }