cwgoes/agenda.md

Created October 10, 2018 04:58

Star () You must be signed in to star a gist
Fork () You must be signed in to fork a gist

Learn more about clone URLs
Clone this repository at <script src="https://gist.github.com/cwgoes/d543134430c001c9d5418e3e3fc24ea9.js"></script>
Save cwgoes/d543134430c001c9d5418e3e3fc24ea9 to your computer and use it in GitHub Desktop.

Download ZIP

Cosmos SDK <=> Iris SDK Sync 17/10/2018

Raw

Followup on cosmos/cosmos-sdk#2372

abelliumnt commented Oct 23, 2018 •

edited

Loading

I noticed that the mint module has been implemented. But I have a confusion about ProcessProvisions. The inflation tokens has not been added to loosenToken. To my understand, the loosenToken should contains all the stake token existing in the blockchain. So the inflation tokens should be added to loosenToken.
Is my understanding correctly? If so, does this mean there is a bug in mint moudle?

abelliumnt commented Oct 23, 2018 •

edited

Loading

In unbonding and redelegating, why the truncated token should be burned?
https://github.com/cosmos/cosmos-sdk/blob/7f43860ca95a2375840490d99ff1b05a0907961f/x/stake/keeper/delegation.go#L567

Besides, in fee distribution module, the truncated fee tokens are added to community pool:
https://github.com/cosmos/cosmos-sdk/blob/7f43860ca95a2375840490d99ff1b05a0907961f/x/distribution/keeper/delegation.go#L99

abelliumnt commented Oct 24, 2018 •

edited

Loading

I rememder that in previous implementation, allocating collected token to global pool and validator pool took place in endblock. However, now it is in beginBlocker. Why did we make this change? Does this change have some additional consideration?

abelliumnt commented Oct 31, 2018

Suppose there are three validators(A, B, C), and I have only one delegation to A. Then I launch a redelegation from A to B. Before, the completion of this redelegation, can I launch another redelegation from B to C?

abelliumnt commented Oct 31, 2018

Currently, the IBC is premature. Soon the main net will be launch. Once the IBC is mature, we have to upgrade gaiad. Then how do we start main network with historical data?

abelliumnt commented Oct 31, 2018

What is the main purpose of upgrade tendermint to 0.26? I have check the related PR: cosmos/cosmos-sdk#2633.
The main changes contains

Replace UnmarshalBinary with UnmarshalBinaryLengthPrefixed
Refactor merkle proof
However, I didn't found any issues about unmarshal and query proof. Does this upgrade fix some known issues?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment