Skip to content

Instantly share code, notes, and snippets.

View d-webs's full-sized avatar

David Webster d-webs

View GitHub Profile

Papajohns Integration Notes

  • The menu has “Store Fees” in it, i.e. delivery fees. Do we need to care about these?

  • Looking at the createCart API, we will need to store more than just a single ID in items.

    For products:

    • baseProductId - the primary ID of the product (i.e. 107726)
    • code - the product code passed in the menu (i.e. TH:SP-3000)

For modifiers:

@d-webs
d-webs / merchant_markup_v2.md
Last active March 14, 2020 02:01
Merchant Markup - V2

Background

As a part of the menu markup project, we decoupled the concepts of a "Postmates" markup and a "Merchant" markup. Postmates markup is meant to be hidden to the merchant, and only visible to the buyers. Merchant markup is requested by the merchant, and should be visible in all apps (Buyer Frontend, Merchant Tablet, and Catalog Manager). The latter was something we did not previously support, until we introduced the merchant_price_increase feature.

For this new merchant_price_increase, applying a markup entailed actually mutating the catalog itself. This started with a ticket to backfill several thousands of places with the new mutated price, and then subsequently was followed up with features to support price mutations in God mode & the place bulk-updater tool.

The main reasons this approach was taken in the first place were:

  1. It was "simple." Once the price mutation happened, no other apps would have to think about this concept. The conce