Skip to content

Instantly share code, notes, and snippets.

@d

d/scratch.md

Created February 20, 2019 20:16
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save d/34436300684611d4d59ea8ce032b60a7 to your computer and use it in GitHub Desktop.
Save d/34436300684611d4d59ea8ce032b60a7 to your computer and use it in GitHub Desktop.
Download ZIP
Raw
scratch.md

Our tests for pg_upgrade is its own travesty:

  1. It takes no control over its input: let's upgrade whatever is left in the cluster. That means we really don't know how or what we are testing.
  2. It relies on comparing two dumps (one before upgrade, one after upgrade) and asserting that they are verbatim identical. Philosophically speaking, this is sufficient not necessary. Practically, this is wrong.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment