For every pull request for user facing changes, we should include the following in the PR description:
- Images of any visual changes (for each breakpoint: mobile, tablet, desktop)
- Page structure outline when modifying/adding/removing headings or HTML5 sections https://hoyois.github.io/html5outliner/)
- Micro data extraction when adding/modifying RDFa schema (https://developers.google.com/structured-data/testing-tool/)
You should also be checking and optimizing any code being submitted as follows:
- Optimise your changes for speed. Use the YSlow plugin and optimise before submitting a PR
- Clean up your markup by using the HTML5 markup validator https://html5.validator.nu
- Minimise JS and CSS errors by checking the console for errors and warnings
- Meet WCAG 2.0 AA standards using http://wave.webaim.org or one of their browser extensions
When reviewing a PR keep you should:
- Check for missing tests!
- Check for missed opportunities to add micro data from schema.org
- Point out if images or page outline or schema summary is missing from the PR description
- Check for code that can be abstracted into a reusable component
- Identify any possible performance issues
- Identify poor page structure or semantical content
- Identify any possible accessibility issues
- Ensure all HTML and CSS is mobile first responsive