Last active
August 29, 2015 14:15
-
-
Save daniloercoli/cf06dfcf04de24df23a2 to your computer and use it in GitHub Desktop.
Stats - Blog preview new method call
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diff --git WordPress/src/main/java/org/wordpress/android/ui/reader/ReaderActivityLauncher.java WordPress/src/main/java/org/wordpress/android/ui/reader/ReaderActivityLauncher.java | |
index b9ac290..095c466 100644 | |
--- WordPress/src/main/java/org/wordpress/android/ui/reader/ReaderActivityLauncher.java | |
+++ WordPress/src/main/java/org/wordpress/android/ui/reader/ReaderActivityLauncher.java | |
@@ -122,41 +122,6 @@ public class ReaderActivityLauncher { | |
context.startActivity(intent); | |
} | |
- /* | |
- * this method works but is marked deprecated since it should be avoided in favor of | |
- * the version that accepts a blogId rather than a blogUrl (since passing a blogUrl | |
- * requires a potentially expensive lookup of the blogId) | |
- */ | |
- @Deprecated | |
- public static void showReaderBlogPreview(Context context, String blogUrl) { | |
- if (TextUtils.isEmpty(blogUrl)) { | |
- return; | |
- } | |
- | |
- // first try to lookup the blogId in local db... | |
- long blogId = ReaderBlogTable.getBlogIdFromUrl(blogUrl); | |
- if (blogId != 0) { | |
- showReaderBlogPreview(context, blogId); | |
- return; | |
- } | |
- | |
- // ...then request it from endpoint | |
- final WeakReference<Context> weakContext = new WeakReference<>(context); | |
- ReaderBlogActions.updateBlogInfo(0, blogUrl, new ReaderActions.UpdateBlogInfoListener() { | |
- @Override | |
- public void onResult(ReaderBlog blogInfo) { | |
- if (weakContext.get() == null) { | |
- return; | |
- } | |
- if (blogInfo != null && blogInfo.blogId != 0) { | |
- showReaderBlogPreview(weakContext.get(), blogInfo.blogId); | |
- } else { | |
- ToastUtils.showToast(weakContext.get(), R.string.reader_toast_err_get_blog_info); | |
- } | |
- } | |
- }); | |
- } | |
- | |
public static void showReaderBlogPreview(Context context, ReaderPost post) { | |
if (post == null) { | |
return; | |
diff --git WordPress/src/main/java/org/wordpress/android/ui/stats/StatsFollowersFragment.java WordPress/src/main/java/org/wordpress/android/ui/stats/StatsFollowersFragment.java | |
index 90e9c1f..7be629e 100644 | |
--- WordPress/src/main/java/org/wordpress/android/ui/stats/StatsFollowersFragment.java | |
+++ WordPress/src/main/java/org/wordpress/android/ui/stats/StatsFollowersFragment.java | |
@@ -306,7 +306,7 @@ public class StatsFollowersFragment extends StatsAbstractListFragment { | |
public void onClick(View view) { | |
ReaderActivityLauncher.showReaderBlogPreview( | |
context, | |
- currentRowData.getURL() | |
+ followData.getSiteID() | |
); | |
} | |
}); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment