Created
January 20, 2023 01:25
-
-
Save dannon/bd7cb4fafb7538865c15d29829ca2924 to your computer and use it in GitHub Desktop.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[1mdiff --git a/client/src/mvc/visualization/chart/chart-client.js b/client/src/mvc/visualization/chart/chart-client.js[m | |
[1mindex 4a030f5c10..4891596ef2 100644[m | |
[1m--- a/client/src/mvc/visualization/chart/chart-client.js[m | |
[1m+++ b/client/src/mvc/visualization/chart/chart-client.js[m | |
[36m@@ -46,6 +46,7 @@[m [mexport default Backbone.View.extend({[m | |
})[m | |
.done((dataset) => {[m | |
this.dataset = dataset;[m | |
[32m+[m[32m console.debug("LOADING CHART WITH THIS", this);[m | |
this.chart.load();[m | |
})[m | |
.fail((response) => {[m | |
[1mdiff --git a/client/src/mvc/visualization/chart/views/menu.js b/client/src/mvc/visualization/chart/views/menu.js[m | |
[1mindex e1f259704c..283c329767 100644[m | |
[1m--- a/client/src/mvc/visualization/chart/views/menu.js[m | |
[1m+++ b/client/src/mvc/visualization/chart/views/menu.js[m | |
[36m@@ -134,14 +134,14 @@[m [mexport default Backbone.View.extend({[m | |
},[m | |
[m | |
render: function () {[m | |
[31m- var visible = this.model.get("visible");[m | |
[32m+[m[32m const visible = this.model.get("visible");[m | |
this.app.$el[visible ? "removeClass" : "addClass"]("charts-fullscreen");[m | |
[31m- this.execute_button.model.set("visible", visible && !!this.app.chart.plugin.specs.confirm);[m | |
[32m+[m[32m this.execute_button.model.set("visible", visible && !!this.app.chart.plugin.specs?.confirm);[m | |
this.save_button.model.set("visible", visible);[m | |
this.export_button.model.set("visible", visible);[m | |
this.right_button.model.set("visible", visible);[m | |
this.left_button.model.set("visible", !visible);[m | |
[31m- var exports = this.app.chart.plugin.specs.exports || [];[m | |
[32m+[m[32m const exports = this.app.chart.plugin.specs?.exports ?? [];[m | |
this.export_button.collection.each((model) => {[m | |
model.set("visible", exports.indexOf(model.get("key")) !== -1);[m | |
});[m | |
[1mdiff --git a/config/plugins/visualizations/ngl/src/ngl.js b/config/plugins/visualizations/ngl/src/ngl.js[m | |
[1mindex b9d92f73be..7899c56dae 100644[m | |
[1m--- a/config/plugins/visualizations/ngl/src/ngl.js[m | |
[1m+++ b/config/plugins/visualizations/ngl/src/ngl.js[m | |
[36m@@ -21,7 +21,7 @@[m [mwindow.bundleEntries.load = function (options) {[m | |
stage_parameters = { ext: dataset.extension, defaultRepresentation: true };[m | |
const safe_download_url = `${options.root}${dataset.download_url}`;[m | |
try {[m | |
[31m- stage.loadFile(safe_download_url, stage_parameters).then(function (component) {[m | |
[32m+[m[32m stage.loadFile(dataset.download_url, stage_parameters).then(function (component) {[m | |
component.addRepresentation(settings.get("mode"), representation_parameters);[m | |
options.chart.state("ok", "Chart drawn.");[m | |
options.process.resolve();[m |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment