Skip to content

Instantly share code, notes, and snippets.

@dannon
Created January 20, 2023 01:25
Show Gist options
  • Save dannon/bd7cb4fafb7538865c15d29829ca2924 to your computer and use it in GitHub Desktop.
Save dannon/bd7cb4fafb7538865c15d29829ca2924 to your computer and use it in GitHub Desktop.
diff --git a/client/src/mvc/visualization/chart/chart-client.js b/client/src/mvc/visualization/chart/chart-client.js
index 4a030f5c10..4891596ef2 100644
--- a/client/src/mvc/visualization/chart/chart-client.js
+++ b/client/src/mvc/visualization/chart/chart-client.js
@@ -46,6 +46,7 @@ export default Backbone.View.extend({
})
.done((dataset) => {
this.dataset = dataset;
+ console.debug("LOADING CHART WITH THIS", this);
this.chart.load();
})
.fail((response) => {
diff --git a/client/src/mvc/visualization/chart/views/menu.js b/client/src/mvc/visualization/chart/views/menu.js
index e1f259704c..283c329767 100644
--- a/client/src/mvc/visualization/chart/views/menu.js
+++ b/client/src/mvc/visualization/chart/views/menu.js
@@ -134,14 +134,14 @@ export default Backbone.View.extend({
},

render: function () {
- var visible = this.model.get("visible");
+ const visible = this.model.get("visible");
this.app.$el[visible ? "removeClass" : "addClass"]("charts-fullscreen");
- this.execute_button.model.set("visible", visible && !!this.app.chart.plugin.specs.confirm);
+ this.execute_button.model.set("visible", visible && !!this.app.chart.plugin.specs?.confirm);
this.save_button.model.set("visible", visible);
this.export_button.model.set("visible", visible);
this.right_button.model.set("visible", visible);
this.left_button.model.set("visible", !visible);
- var exports = this.app.chart.plugin.specs.exports || [];
+ const exports = this.app.chart.plugin.specs?.exports ?? [];
this.export_button.collection.each((model) => {
model.set("visible", exports.indexOf(model.get("key")) !== -1);
});
diff --git a/config/plugins/visualizations/ngl/src/ngl.js b/config/plugins/visualizations/ngl/src/ngl.js
index b9d92f73be..7899c56dae 100644
--- a/config/plugins/visualizations/ngl/src/ngl.js
+++ b/config/plugins/visualizations/ngl/src/ngl.js
@@ -21,7 +21,7 @@ window.bundleEntries.load = function (options) {
stage_parameters = { ext: dataset.extension, defaultRepresentation: true };
const safe_download_url = `${options.root}${dataset.download_url}`;
try {
- stage.loadFile(safe_download_url, stage_parameters).then(function (component) {
+ stage.loadFile(dataset.download_url, stage_parameters).then(function (component) {
component.addRepresentation(settings.get("mode"), representation_parameters);
options.chart.state("ok", "Chart drawn.");
options.process.resolve();
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment