Skip to content

Instantly share code, notes, and snippets.

@darkdh
Last active October 8, 2019 00:10
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save darkdh/b9ea16cfa08313419f702bacf8c4cc4b to your computer and use it in GitHub Desktop.
Save darkdh/b9ea16cfa08313419f702bacf8c4cc4b to your computer and use it in GitHub Desktop.
Sync broken cases

Issues awaiting Pull Requests

  1. brave/sync#333 (BrianJ, Anthony)

    • device ID potential conflict (more than one device with the same ID)
  2. brave/sync#261 (Alexey)

  3. When initial setup doesn't complete, sync will remain enabled

  4. New device to old sync chain takes forever to sync due to huge amounts of records (Jimmy, Anthony)

Issues having Pull Requests

  1. Orphan sync chain, when all devices left sync chain and will never to be used again. (Ev)
  2. Consecutive sync record CREATE, UPDATE won't be applied on receiving end (Anthony)
  3. "Other bookmarks" on desktop cause problem for iOS and Android to maintain bookmark consistency (Anthony)

Not included in mid November

  1. order grows endless if we keep reposition bookmark in front of other (leave this in long term fix)
    1. A, B => B, A (move B) => A, B (move A), ..... so the order would look like (1.0.0.0.0.0.0...0.1 and 1.0.0.0.0...1)
    2. A real world example 1.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.1.0.0.0.0.3.68
    3. This is the trade off of not using UniquePosition but also wants to emit changes for only the moving bookmark
      • It used to recalculate the position of all bookmarks after the one we move
  2. Unnecessary resend (brave/brave-browser#6283)
    1. leave and rejoin previous sync chain
      • desktop and iOS
    2. flip sync bookmark toggle off and on
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment