Last active
October 30, 2017 21:24
-
-
Save davdunc/6babcbbe77a5e573dd2386190fd7ef6f to your computer and use it in GitHub Desktop.
snapcraft output
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ubuntu@ip-10-0-0-244:~/sandbox/amazon-ssm-agent$ snapcraft | |
Preparing to pull ssm-agent | |
Pulling ssm-agent | |
Preparing to build ssm-agent | |
Building ssm-agent | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/Tools/src/checkstyle.sh | |
Run checkstyle script | |
Run 'gofmt' | |
Try update 'goimports' | |
Run 'goimports' | |
Try update 'golint' | |
Run 'golint' | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/agent_parser.go:143:15: error strings should not be capitalized or end with punctuation or a newline | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/agent_parser.go:217:27: error strings should not be capitalized or end with punctuation or a newline | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/agentlogstocloudwatch/cloudwatchlogspublisher/cloudwatchlogs_publisher.go:60:2: struct field accessKeyId should be accessKeyID | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/agentlogstocloudwatch/cloudwatchlogspublisher/mock/cloudwatchlogsservice_mock.go:16:1: don't use an underscore in package name | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/agentlogstocloudwatch/cloudwatchlogsqueue/cloudwatchlogs_data_facade.go:49:2: exported const QueueActivated should have comment (or a comment on this block) or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/agentlogstocloudwatch/cloudwatchlogsqueue/cloudwatchlogs_data_facade.go:86:21: error strings should not be capitalized or end with punctuation or a newline | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/appconfig/appconfig_parser.go:73:1: comment on exported function GetDefaultEndPoint should be of the form "GetDefaultEndPoint ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/appconfig/constants.go:20:2: comment on exported const DefaultAgentName should be of the form "DefaultAgentName ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/appconfig/constants.go:23:2: exported const DefaultCommandWorkersLimit should have comment (or a comment on this block) or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/appconfig/constants.go:34:2: comment on exported const DefaultSsmHealthFrequencyMinutes should be of the form "DefaultSsmHealthFrequencyMinutes ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/appconfig/constants.go:43:2: comment on exported const DefaultLocationOfPending should be of the form "DefaultLocationOfPending ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/appconfig/constants.go:51:2: comment on exported const DefaultAssociationLogsRetentionDurationHours should be of the form "DefaultAssociationLogsRetentionDurationHours ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/appconfig/constants.go:56:2: comment on exported const LongRunningPluginsLocation should be of the form "LongRunningPluginsLocation ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/appconfig/constants.go:63:2: comment on exported const InventoryRootDirName should be of the form "InventoryRootDirName ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/appconfig/constants.go:68:2: comment on exported const ComplianceRootDirName should be of the form "ComplianceRootDirName ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/appconfig/constants.go:84:2: comment on exported const ReadWriteAccess should be of the form "ReadWriteAccess ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/appconfig/constants.go:89:2: comment on exported const FileFlagsCreateOrAppend should be of the form "FileFlagsCreateOrAppend ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/appconfig/constants.go:93:2: comment on exported const SuccessExitCode should be of the form "SuccessExitCode ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/appconfig/constants.go:129:2: comment on exported const PluginNameDockerContainer should be of the form "PluginNameDockerContainer ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/appconfig/constants.go:147:2: comment on exported const MaxStdoutLength should be of the form "MaxStdoutLength ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/appconfig/constants.go:152:1: comment on exported var SupportedDocumentVersions should be of the form "SupportedDocumentVersions ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/appconfig/constants_unix.go:72:2: comment on exported const DefaultCustomInventoryFolder should be of the form "DefaultCustomInventoryFolder ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/appconfig/constants_unix.go:75:2: exported const DefaultDocumentWorker should have comment (or a comment on this block) or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/appconfig/constants_unix.go:80:2: comment on exported const ExitCodeTrap should be of the form "ExitCodeTrap ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/appconfig/constants_unix.go:86:2: comment on exported const CommandStoppedPreemptivelyExitCode should be of the form "CommandStoppedPreemptivelyExitCode ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/appconfig/contracts.go:59:2: struct field Url should be URL | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/appconfig/contracts.go:60:2: struct field ChannelId should be ChannelID | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/association/cache/cache.go:9:6: exported type Cache should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/association/cache/cache.go:63:21: method parameter associationId should be associationID | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/association/model/model.go:54:1: receiver name assoc should be consistent with previous receiver name newAssoc for InstanceAssociation | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/association/model/model_test.go:121:2: var assocId should be assocID | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/association/model/model_test.go:156:2: var assocId should be assocID | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/association/model/model_test.go:191:2: var assocId should be assocID | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/association/model/model_test.go:223:2: var assocId should be assocID | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/association/model/model_test.go:251:2: var assocId should be assocID | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/association/model/model_test.go:282:2: var assocId should be assocID | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/association/model/model_test.go:313:2: var assocId should be assocID | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/association/model/model_test.go:340:2: var assocId should be assocID | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/association/model/model_test.go:369:2: var assocId should be assocID | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/association/processor/deps.go:28:6: exported type AssocList should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/association/processor/processor.go:102:1: comment on exported method Processor.InitializeAssociationProcessor should be of the form "InitializeAssociationProcessor ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/association/processor/processor.go:108:9: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/association/processor/processor.go:433:1: receiver name r should be consistent with previous receiver name p for Processor | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/association/processor/processor.go:460:20: var outputUrl should be outputURL | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/association/processor/processor.go:475:1: receiver name r should be consistent with previous receiver name p for Processor | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/association/processor/processor.go:493:20: var outputUrl should be outputURL | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/association/processor/processor.go:515:1: receiver name r should be consistent with previous receiver name p for Processor | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/association/processor/processor.go:580:119: func result outputUrl should be outputURL | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/association/processor/processor_integ_test.go:37:2: don't use ALL_CAPS in Go names; use CamelCase | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/association/processor/processor_integ_test.go:38:2: don't use ALL_CAPS in Go names; use CamelCase | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/association/processor/processor_integ_test.go:39:2: don't use ALL_CAPS in Go names; use CamelCase | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/association/processor/processor_integ_test.go:51:2: var assocId should be assocID | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/association/processor/processor_integ_test.go:122:2: var assocId should be assocID | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/association/rateexpr/rateexpr.go:27:1: comment on exported type RateExpression should be of the form "RateExpression ..." (with optional leading article) | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/association/rateexpr/rateexpr.go:44:26: error strings should not be capitalized or end with punctuation or a newline | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/association/rateexpr/rateexpr.go:49:26: error strings should not be capitalized or end with punctuation or a newline | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/association/rateexpr/rateexpr.go:54:27: error strings should not be capitalized or end with punctuation or a newline | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/association/rateexpr/rateexpr.go:59:27: error strings should not be capitalized or end with punctuation or a newline | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/association/rateexpr/rateexpr.go:65:27: error strings should not be capitalized or end with punctuation or a newline | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/association/rateexpr/rateexpr.go:86:25: error strings should not be capitalized or end with punctuation or a newline | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/association/scheduleexpression/scheduleexpression.go:39:1: exported function CreateScheduleExpression should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/association/scheduleexpression/scheduleexpression.go:54:10: if block ends with a return statement, so drop this else and outdent its block | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/association/scheduleexpression/scheduleexpression.go:66:10: if block ends with a return statement, so drop this else and outdent its block | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/association/schedulemanager/schedulemanager.go:92:11: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/association/schedulemanager/schedulemanager.go:185:1: exported function AssociationExists should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/association/service/service.go:42:2: const NoOutputUrl should be NoOutputURL | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/association/service/service.go:42:2: exported const NoOutputUrl should have comment (or a comment on this block) or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/association/service/service.go:45:6: type associationApiMode should be associationAPIMode | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/association/service/service.go:53:2: var currentAssociationApiMode should be currentAssociationAPIMode | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/association/service/service.go:53:28: should omit type associationApiMode from declaration of var currentAssociationApiMode; it will be inferred from the right-hand side | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/association/service/service.go:77:3: interface method parameter outputUrl should be outputURL | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/association/service/service.go:158:30: method setAssociationApiMode should be setAssociationAPIMode | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/association/service/service.go:219:2: method parameter outputUrl should be outputURL | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/association/service/service.go:240:4: var s3OutputUrl should be s3OutputURL | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/association/service/service.go:282:1: comment on exported method AssociationService.IsInstanceAssociationApiMode should be of the form "IsInstanceAssociationApiMode ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/association/service/service.go:283:30: method IsInstanceAssociationApiMode should be IsInstanceAssociationAPIMode | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/association/service/service.go:317:2: redundant if ...; err != nil check, just return error instead. | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/association/service/test_service.go:61:2: method parameter outputUrl should be outputURL | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/association/service/test_service.go:79:1: comment on exported method AssociationServiceMock.IsInstanceAssociationApiMode should be of the form "IsInstanceAssociationApiMode ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/association/service/test_service.go:80:34: method IsInstanceAssociationApiMode should be IsInstanceAssociationAPIMode | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/cli/cli.go:27:1: comment on exported function RunCommand should be of the form "RunCommand ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/cli/cli.go:64:1: error should be the last type when returning multiple items | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/cli/clicommand/getcommand.go:69:2: struct field CommandIdFlag should be CommandIDFlag | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/cli/clicommand/getcommand.go:77:6: exported type GetOfflineCommand should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/cli/clicommand/getcommand.go:82:1: error should be the last type when returning multiple items | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/cli/clicommand/getcommand.go:127:6: var commandIdLen should be commandIDLen | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/cli/clicommand/getcommand.go:148:1: error should be the last type when returning multiple items | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/cli/clicommand/getinstanceinformation.go:68:6: exported type GetInstanceInformationCommand should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/cli/clicommand/getinstanceinformation.go:73:1: error should be the last type when returning multiple items | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/cli/clicommand/getinstanceinformation.go:83:9: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/cli/clicommand/getinstanceinformation.go:87:5: var instanceId should be instanceID | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/cli/clicommand/getinstanceinformation.go:89:9: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/cli/clicommand/getinstanceinformation.go:125:11: should omit 2nd value from range; this loop is equivalent to `for key := range ...` | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/cli/clicommand/sendcommand.go:80:6: exported type SendOfflineCommand should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/cli/clicommand/sendcommand.go:85:1: error should be the last type when returning multiple items | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/cli/clicommand/sendcommand.go:153:1: error should be the last type when returning multiple items | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/cli/clicommand/sendcommand.go:168:9: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/cli/clicommand/sendcommand.go:193:1: error should be the last type when returning multiple items | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/cli/clicommand/sendcommand.go:208:17: var commandId should be commandID | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/cli/clicommand/sendcommand.go:218:16: var commandId should be commandID | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/cli/cliutil/cliutil.go:25:2: exported const HelpFlag should have comment (or a comment on this block) or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/cli/cliutil/cliutil.go:48:1: comment on exported function Register should be of the form "Register ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/cli/cliutil/cliutil.go:85:6: func ValidJson should be ValidJSON | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/cli/cliutil/cliutil.go:91:6: func ValidUrl should be ValidURL | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/cli/cliutil/cliutil.go:95:8: var errUrl should be errURL | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/compliance/model/model.go:25:7: exported const UNSPECIFIED should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/compliance/model/model.go:26:7: exported const COMPLIANT should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/compliance/model/model.go:27:7: don't use ALL_CAPS in Go names; use CamelCase | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/compliance/model/model.go:27:7: exported const NON_COMPLIANT should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/compliance/model/model.go:29:5: don't use ALL_CAPS in Go names; use CamelCase | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/compliance/model/model.go:29:5: exported var ASSOCIATION_COMPLIANCE_TITLE should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/compliance/model/model.go:31:6: exported type AssociationComplianceItem should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/compliance/model/model.go:33:2: struct field AssociationId should be AssociationID | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/compliance/model/model.go:46:1: comment on exported function UpdateAssociationComplianceItem should be of the form "UpdateAssociationComplianceItem ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/compliance/model/model.go:49:38: func parameter associationId should be associationID | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/compliance/model/model.go:99:1: comment on exported function RefreshAssociationComplianceItems should be of the form "RefreshAssociationComplianceItems ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/compliance/model/model.go:122:1: exported function GetAssociationComplianceEntries should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/compliance/uploader/test_uploader.go:24:6: type name will be used as compliance.ComplianceUploaderMock by other packages, and that stutters; consider calling this UploaderMock | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/compliance/uploader/test_uploader.go:33:1: exported method ComplianceUploaderMock.CreateNewServiceIfUnHealthy should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/compliance/uploader/test_uploader.go:37:1: exported method ComplianceUploaderMock.UpdateAssociationCompliance should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/compliance/uploader/test_uploader.go:37:62: method parameter associationId should be associationID | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/compliance/uploader/test_uploader.go:37:84: method parameter instanceId should be instanceID | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/compliance/uploader/uploader.go:40:2: exported const Name should have comment (or a comment on this block) or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/compliance/uploader/uploader.go:51:30: interface method parameter associationId should be associationID | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/compliance/uploader/uploader.go:51:52: interface method parameter instanceId should be instanceID | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/compliance/uploader/uploader.go:54:1: comment on exported type ComplianceUploader should be of the form "ComplianceUploader ..." (with optional leading article) | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/compliance/uploader/uploader.go:55:6: type name will be used as compliance.ComplianceUploader by other packages, and that stutters; consider calling this Uploader | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/compliance/uploader/uploader.go:63:1: comment on exported function NewComplianceUploader should be of the form "NewComplianceUploader ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/compliance/uploader/uploader.go:87:1: exported method ComplianceUploader.CreateNewServiceIfUnHealthy should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/compliance/uploader/uploader.go:109:1: comment on exported method ComplianceUploader.UpdateAssociationCompliance should be of the form "UpdateAssociationCompliance ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/compliance/uploader/uploader.go:112:58: method parameter associationId should be associationID | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/compliance/uploader/uploader.go:112:80: method parameter instanceId should be instanceID | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/compliance/uploader/uploader.go:152:1: comment on exported method ComplianceUploader.ConvertToSsmAssociationComplianceItems should be of the form "ConvertToSsmAssociationComplianceItems ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/compliance/uploader/uploader.go:177:9: if block ends with a return statement, so drop this else and outdent its block | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/context/test_context.go:74:1: comment on exported method Mock.CurrentContext should be of the form "CurrentContext ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/contracts/aggregator.go:14:1: package comment should be of the form "Package contracts ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/contracts/aggregator.go:61:1: exported function DocumentResultAggregator should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/contracts/compatibility.go:14:1: package comment should be of the form "Package contracts ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/contracts/document.go:14:1: package comment should be of the form "Package contracts ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/contracts/document.go:45:2: struct field Id should be ID | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/contracts/document.go:48:6: exported type OSProcInfo should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/contracts/document.go:100:1: exported function UpdateDocState should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/contracts/model.go:23:2: exported const ResultStatusNotStarted should have comment (or a comment on this block) or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/contracts/model.go:34:1: exported method ResultStatus.IsSuccess should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/contracts/model.go:43:1: exported method ResultStatus.IsReboot should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/contracts/model.go:86:2: comment on exported const AssociationStatusPending should be of the form "AssociationStatusPending ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/contracts/model.go:104:2: comment on exported const AssociationErrorCodeInvalidAssociation should be of the form "AssociationErrorCodeInvalidAssociation ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/contracts/model.go:125:2: comment on exported const AssociationPendingMessage should be of the form "AssociationPendingMessage ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/contracts/model.go:127:2: comment on exported const AssociationInProgressMessage should be of the form "AssociationInProgressMessage ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/contracts/model.go:138:6: exported type StopType should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/contracts/model.go:141:2: exported const StopTypeSoftStop should have comment (or a comment on this block) or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/contracts/model.go:219:6: exported type DocumentResult should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/contracts/plugin.go:86:2: struct field MessageId should be MessageID | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/contracts/plugin.go:139:1: exported method PluginOutput.Merge should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/contracts/plugin.go:153:1: receiver name out should be consistent with previous receiver name p for PluginOutput | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/contracts/plugin.go:165:1: receiver name out should be consistent with previous receiver name p for PluginOutput | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/contracts/plugin.go:171:1: receiver name out should be consistent with previous receiver name p for PluginOutput | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/contracts/plugin.go:177:1: receiver name out should be consistent with previous receiver name p for PluginOutput | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/contracts/plugin.go:183:1: receiver name out should be consistent with previous receiver name p for PluginOutput | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/contracts/plugin.go:189:1: receiver name out should be consistent with previous receiver name p for PluginOutput | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/contracts/plugin.go:195:1: receiver name out should be consistent with previous receiver name p for PluginOutput | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/contracts/plugin.go:207:1: receiver name out should be consistent with previous receiver name p for PluginOutput | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/contracts/plugin.go:215:1: receiver name out should be consistent with previous receiver name p for PluginOutput | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/contracts/plugin.go:227:1: receiver name out should be consistent with previous receiver name p for PluginOutput | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/contracts/plugin.go:234:1: comment on exported method PluginOutput.GetStatus should be of the form "GetStatus ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/contracts/plugin.go:235:1: receiver name out should be consistent with previous receiver name p for PluginOutput | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/contracts/plugin.go:236:1: exported method PluginOutput.GetStdout should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/contracts/plugin.go:236:1: receiver name out should be consistent with previous receiver name p for PluginOutput | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/contracts/plugin.go:237:1: exported method PluginOutput.GetStderr should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/contracts/plugin.go:237:1: receiver name out should be consistent with previous receiver name p for PluginOutput | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/contracts/plugin.go:238:1: exported method PluginOutput.GetExitCode should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/contracts/plugin.go:238:1: receiver name out should be consistent with previous receiver name p for PluginOutput | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/contracts/plugin.go:240:1: exported method PluginOutput.SetStatus should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/contracts/plugin.go:240:1: receiver name out should be consistent with previous receiver name p for PluginOutput | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/contracts/plugin.go:241:1: exported method PluginOutput.SetStdout should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/contracts/plugin.go:241:1: receiver name out should be consistent with previous receiver name p for PluginOutput | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/contracts/plugin.go:242:1: exported method PluginOutput.SetStderr should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/contracts/plugin.go:242:1: receiver name out should be consistent with previous receiver name p for PluginOutput | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/contracts/plugin.go:243:1: exported method PluginOutput.SetExitCode should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/contracts/plugin.go:243:1: receiver name out should be consistent with previous receiver name p for PluginOutput | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/contracts/plugin.go:283:1: comment on exported function IsPreconditionEnabled should be of the form "IsPreconditionEnabled ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/docparser/docparser.go:34:6: exported type DocumentParserInfo should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/docparser/docparser.go:38:2: struct field MessageId should be MessageID | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/docparser/docparser.go:39:2: struct field DocumentId should be DocumentID | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/docparser/docparser.go:231:2: redundant if ...; err != nil check, just return error instead. | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/executers/executers.go:37:2: const envVarInstanceId should be envVarInstanceID | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/executers/executers.go:485:1: exported function QuoteShString should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/executers/executers.go:490:1: exported function QuotePsString should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/executers/executers_test.go:29:2: const testInstanceId should be testInstanceID | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/executers/executers_unix.go:62:4: should replace i += 1 with i++ | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/fileutil/fileutil.go:32:6: exported type ByteOrderMark should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/fileutil/fileutil.go:35:2: exported const ByteOrderMarkEmit should have comment (or a comment on this block) or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/fileutil/fileutil.go:39:1: exported function CreateUTF8ByteOrderMark should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/fileutil/fileutil_test.go:139:2: don't use underscores in Go names; var name1_removed should be name1Removed | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/fileutil/fileutil_test.go:140:2: don't use underscores in Go names; var name3_removed should be name3Removed | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/fileutil/fileutil_test.go:141:2: don't use underscores in Go names; var name4_removed should be name4Removed | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/fileutil/harden.go:10:2: exported const RWPermission should have comment (or a comment on this block) or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/fileutil/harden_unix.go:24:2: const rootUid should be rootUID | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/fingerprint/fingerprint.go:49:1: exported function InstanceFingerprint should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/fingerprint/fingerprint.go:67:1: exported function SetSimilarityThreshold should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/fingerprint/fingerprint.go:69:21: error strings should not be capitalized or end with punctuation or a newline | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/fingerprint/fingerprint.go:154:2: redundant if ...; err != nil check, just return error instead. | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/fingerprint/fingerprint.go:204:6: func primaryIpInfo should be primaryIPInfo | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/fingerprint/fingerprint_deps.go:1:1: package comment should be of the form "Package fingerprint ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/fingerprint/fingerprint_test.go:42:2: var savedJson should be savedJSON | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/fingerprint/fingerprint_test.go:150:2: var savedJson should be savedJSON | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/framework/coremanager/coremanager.go:48:21: func parameter instanceIdPtr should be instanceIDPtr | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/framework/coremanager/coremanager.go:80:6: var instanceId should be instanceID | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/framework/docmanager/docmanager.go:37:6: exported type DocumentMgr should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/framework/docmanager/docmanager.go:44:1: comment on exported type DocumentFileMgr should be of the form "DocumentFileMgr ..." (with optional leading article) | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/framework/docmanager/docmanager.go:53:1: exported function NewDocumentFileMgr should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/framework/docmanager/docmanager.go:61:1: exported method DocumentFileMgr.MoveDocumentState should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/framework/docmanager/docmanager.go:83:1: exported method DocumentFileMgr.PersistDocumentState should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/framework/docmanager/docmanager.go:107:1: exported method DocumentFileMgr.GetDocumentState should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/framework/docmanager/docmanager.go:132:1: comment on exported method DocumentFileMgr.RemoveDocumentState should be of the form "RemoveDocumentState ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/framework/docmanager/docmanager.go:145:1: comment on exported function DocumentStateDir should be of the form "DocumentStateDir ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/framework/docmanager/docmanager.go:208:4: should replace countOfDeletions += 1 with countOfDeletions++ | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/framework/processor/processor.go:40:6: exported type ExecuterCreator should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/framework/processor/processor.go:48:6: exported type Processor should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/framework/processor/processor.go:61:6: exported type EngineProcessor should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/framework/processor/processor.go:72:1: comment on exported function NewEngineProcessor should be of the form "NewEngineProcessor ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/framework/processor/processor.go:98:1: exported method EngineProcessor.Start should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/framework/processor/processor.go:118:1: comment on exported method EngineProcessor.Submit should be of the form "Submit ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/framework/processor/processor.go:154:1: exported method EngineProcessor.Cancel should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/framework/processor/executer/executer.go:39:1: comment on exported type DocumentFileStore should be of the form "DocumentFileStore ..." (with optional leading article) | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/framework/processor/executer/executer.go:50:1: exported function NewDocumentFileStore should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/framework/processor/executer/executer.go:74:1: comment on exported method DocumentFileStore.Load should be of the form "Load ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/framework/processor/executer/basicexecuter/basicexecuter.go:14:1: package comment should be of the form "Package basicexecuter ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/framework/processor/executer/basicexecuter/basicexecuter.go:29:1: comment on exported type BasicExecuter should be of the form "BasicExecuter ..." (with optional leading article) | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/framework/processor/executer/basicexecuter/basicexecuter.go:126:1: exported method BasicExecuter.Run should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/framework/processor/executer/basicexecuter/basicexecuter_test.go:32:2: struct field MsgId should be MsgID | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/framework/processor/executer/mock/executer.go:14:1: package comment should be of the form "Package executermocks ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/framework/processor/executer/mock/executer.go:24:6: exported type MockedExecuter should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/framework/processor/executer/mock/executer.go:28:1: exported function NewMockExecuter should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/framework/processor/executer/mock/executer.go:32:1: exported method MockedExecuter.Run should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/framework/processor/executer/mock/executer.go:39:6: exported type MockDocumentStore should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/framework/processor/executer/mock/executer.go:43:1: exported method MockDocumentStore.Save should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/framework/processor/executer/mock/executer.go:48:1: exported method MockDocumentStore.Load should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/framework/processor/executer/outofproc/master.go:20:6: exported type Backend should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/framework/processor/executer/outofproc/master.go:30:6: exported type OutOfProcExecuter should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/framework/processor/executer/outofproc/master.go:30:6: type name will be used as outofproc.OutOfProcExecuter by other packages, and that stutters; consider calling this Executer | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/framework/processor/executer/outofproc/master.go:55:1: exported function NewOutOfProcExecuter should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/framework/processor/executer/outofproc/master.go:62:1: comment on exported method OutOfProcExecuter.Run should be of the form "Run ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/framework/processor/executer/outofproc/master.go:83:9: if block ends with a return statement, so drop this else and outdent its block | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/framework/processor/executer/outofproc/master.go:175:10: if block ends with a return statement, so drop this else and outdent its block | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/framework/processor/executer/outofproc/master.go:190:1: exported method OutOfProcExecuter.WaitForProcess should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/framework/processor/executer/outofproc/channel/channel.go:13:2: exported const ModeMaster should have comment (or a comment on this block) or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/framework/processor/executer/outofproc/channel/channel.go:21:6: exported type Mode should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/framework/processor/executer/outofproc/channel/channel.go:35:1: comment on exported function CreateFileChannel should be of the form "CreateFileChannel ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/framework/processor/executer/outofproc/channel/channel.go:38:1: error should be the last type when returning multiple items | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/framework/processor/executer/outofproc/channel/filechannel.go:46:1: comment on exported function NewFileWatcherChannel should be of the form "NewFileWatcherChannel ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/framework/processor/executer/outofproc/channel/filechannel.go:52:67: exported func NewFileWatcherChannel returns unexported type *channel.fileWatcherChannel, which can be annoying to use | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/framework/processor/executer/outofproc/channel/filechannel.go:116:36: method parameter rawJson should be rawJSON | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/framework/processor/executer/outofproc/channel/filechannel.go:125:2: don't use underscores in Go names; var tmp_filepath should be tmpFilepath | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/framework/processor/executer/outofproc/channel/mock/channel.go:5:6: exported type MockedChannel should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/framework/processor/executer/outofproc/channel/mock/channel.go:9:1: exported method MockedChannel.Send should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/framework/processor/executer/outofproc/channel/mock/channel.go:14:1: exported method MockedChannel.GetMessage should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/framework/processor/executer/outofproc/channel/mock/channel.go:19:1: exported method MockedChannel.Close should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/framework/processor/executer/outofproc/channel/mock/channel.go:24:1: exported method MockedChannel.Destroy should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/framework/processor/executer/outofproc/channel/mock/fake_channel.go:44:6: exported type FakeChannel should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/framework/processor/executer/outofproc/channel/mock/fake_channel.go:54:9: if block ends with a return statement, so drop this else and outdent its block | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/framework/processor/executer/outofproc/channel/mock/fake_channel.go:59:1: exported function NewFakeChannel should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/framework/processor/executer/outofproc/channel/mock/fake_channel.go:94:1: exported method FakeChannel.Send should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/framework/processor/executer/outofproc/channel/mock/fake_channel.go:98:9: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/framework/processor/executer/outofproc/channel/mock/fake_channel.go:105:1: exported method FakeChannel.GetMessage should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/framework/processor/executer/outofproc/channel/mock/fake_channel.go:109:1: comment on exported method FakeChannel.Close should be of the form "Close ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/framework/processor/executer/outofproc/channel/mock/fake_channel.go:120:1: exported method FakeChannel.Destroy should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/framework/processor/executer/outofproc/channel/mock/fake_channel.go:129:1: exported function IsExists should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/framework/processor/executer/outofproc/messaging/backend.go:19:6: exported type PluginRunner should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/framework/processor/executer/outofproc/messaging/backend.go:26:1: comment on exported type WorkerBackend should be of the form "WorkerBackend ..." (with optional leading article) | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/framework/processor/executer/outofproc/messaging/backend.go:36:1: comment on exported type ExecuterBackend should be of the form "ExecuterBackend ..." (with optional leading article) | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/framework/processor/executer/outofproc/messaging/backend.go:46:1: exported function NewExecuterBackend should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/framework/processor/executer/outofproc/messaging/backend.go:74:1: exported method ExecuterBackend.Accept should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/framework/processor/executer/outofproc/messaging/backend.go:78:1: exported method ExecuterBackend.Stop should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/framework/processor/executer/outofproc/messaging/backend.go:82:1: comment on exported method ExecuterBackend.Process should be of the form "Process ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/framework/processor/executer/outofproc/messaging/backend.go:113:1: exported function NewWorkerBackend should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/framework/processor/executer/outofproc/messaging/backend.go:124:1: exported method WorkerBackend.Process should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/framework/processor/executer/outofproc/messaging/backend.go:197:1: exported method WorkerBackend.Accept should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/framework/processor/executer/outofproc/messaging/backend.go:201:1: exported method WorkerBackend.Stop should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/framework/processor/executer/outofproc/messaging/messaging.go:11:6: exported type MessageType should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/framework/processor/executer/outofproc/messaging/messaging.go:28:6: exported type Message should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/framework/processor/executer/outofproc/messaging/messaging.go:35:6: type name will be used as messaging.MessagingBackend by other packages, and that stutters; consider calling this Backend | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/framework/processor/executer/outofproc/messaging/messaging.go:67:1: comment on exported function ParseDatagram should be of the form "ParseDatagram ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/framework/processor/executer/outofproc/proc/process.go:14:1: package comment should be of the form "Package proc ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/framework/processor/executer/outofproc/proc/process.go:42:1: comment on exported type WorkerProcess should be of the form "WorkerProcess ..." (with optional leading article) | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/framework/processor/executer/outofproc/proc/process.go:48:1: exported method WorkerProcess.Pid should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/framework/processor/executer/outofproc/proc/process.go:52:1: exported method WorkerProcess.StartTime should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/framework/processor/executer/outofproc/proc/process.go:56:1: comment on exported method WorkerProcess.Kill should be of the form "Kill ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/framework/processor/executer/outofproc/proc/process.go:61:1: exported method WorkerProcess.Wait should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/framework/processor/executer/outofproc/proc/process.go:65:1: comment on exported function StartProcess should be of the form "StartProcess ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/framework/processor/executer/outofproc/proc/process.go:79:1: comment on exported function IsProcessExists should be of the form "IsProcessExists ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/framework/processor/executer/outofproc/proc/process.go:89:1: comment on exported function ParseArgv should be of the form "ParseArgv ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/framework/processor/executer/outofproc/proc/process.go:104:1: exported function FormArgv should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/framework/processor/executer/outofproc/proc/process_unix.go:16:1: package comment should be of the form "Package proc ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/framework/processor/executer/outofproc/proc/process_unix.go:40:6: don't use underscores in Go names; func find_process should be findProcess | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/framework/processor/executer/outofproc/proc/process_unix.go:45:2: don't use underscores in Go names; var proc_list should be procList | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/framework/processor/executer/outofproc/proc/mock/proc.go:9:6: exported type MockedOSProcess should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/framework/processor/executer/outofproc/proc/mock/proc.go:13:1: exported method MockedOSProcess.Pid should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/framework/processor/executer/outofproc/proc/mock/proc.go:18:1: exported method MockedOSProcess.StartTime should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/framework/processor/executer/outofproc/proc/mock/proc.go:23:1: exported method MockedOSProcess.Kill should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/framework/processor/executer/outofproc/proc/mock/proc.go:28:1: exported method MockedOSProcess.Wait should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/framework/processor/mock/processor.go:8:6: exported type MockedProcessor should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/framework/processor/mock/processor.go:12:1: exported method MockedProcessor.Start should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/framework/processor/mock/processor.go:17:1: exported method MockedProcessor.Stop should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/framework/processor/mock/processor.go:22:1: exported method MockedProcessor.Submit should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/framework/processor/mock/processor.go:27:1: exported method MockedProcessor.Cancel should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/framework/runpluginutil/runpluginutil.go:44:5: exported var SSMPluginRegistry should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/framework/runpluginutil/runpluginutil.go:69:1: comment on exported function RunPlugins should be of the form "RunPlugins ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/framework/runpluginutil/runpluginutil.go:204:27: error strings should not be capitalized or end with punctuation or a newline | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/framework/runpluginutil/runpluginutil.go:216:2: func parameter pluginId should be pluginID | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/framework/runpluginutil/runpluginutil.go:289:11: if block ends with a return statement, so drop this else and outdent its block | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/framework/runpluginutil/test_plugin.go:26:1: comment on exported type PluginMock should be of the form "PluginMock ..." (with optional leading article) | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/health/healthcheck.go:30:6: type name will be used as health.HealthCheck by other packages, and that stutters; consider calling this Check | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/health/healthcheck.go:39:2: exported const AgentName should have comment (or a comment on this block) or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/health/healthcheck.go:96:1: comment on exported method HealthCheck.ModuleName should be of the form "ModuleName ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/health/healthcheck.go:101:1: comment on exported method HealthCheck.ModuleExecute should be of the form "ModuleExecute ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/health/healthcheck.go:123:1: comment on exported method HealthCheck.ModuleRequestStop should be of the form "ModuleRequestStop ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/hummingbird/module/hummingbird.go:36:6: exported type Channel should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/hummingbird/module/hummingbird.go:37:2: struct field channelId should be channelID | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/hummingbird/module/hummingbird.go:100:2: var channelId should be channelID | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/hummingbird/module/hummingbird.go:119:1: comment on exported method HummingBird.ModuleRequestStop should be of the form "ModuleRequestStop ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/hummingbird/service/service.go:27:47: interface method result channelId should be channelID | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/hummingbird/service/service.go:28:24: interface method parameter channelId should be channelID | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/hummingbird/service/service.go:29:27: interface method parameter channelId should be channelID | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/hummingbird/service/service.go:56:75: method result channelId should be channelID | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/hummingbird/service/service.go:61:52: method parameter channelId should be channelID | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/hummingbird/service/service.go:66:55: method parameter channelId should be channelID | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/log/cwconfiglog.go:14:1: package comment should be of the form "Package log ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/log/cwconfiglog.go:68:6: don't use underscores in Go names; var unexposed_string should be unexposedString | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/log/defaultconfig.go:21:1: exported function DefaultConfig should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/log/defaultconfig.go:25:1: exported function LoadLog should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/log/log.go:26:2: exported const LogFile should have comment (or a comment on this block) or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/log/log.go:30:5: exported var SeelogDefault should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/log/log.go:31:5: exported var LoggerInstance should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/log/log.go:32:5: exported var PkgMutex should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/log/log.go:34:1: exported function Logger should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/log/log.go:46:1: exported function WithContext should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/log/log.go:89:1: exported function GetLogConfigBytes should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/log/log_unix.go:29:2: exported const DefaultLogDir should have comment (or a comment on this block) or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/log/test_log.go:28:1: comment on exported function NewMockLog should be of the form "NewMockLog ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/log/test_log.go:44:1: exported function NewMockLogWithContext should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/log/ssmlog/ssmlog.go:39:1: exported function SSMLogger should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/longrunning/deps.go:25:6: exported type FileSysUtil should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/longrunning/deps.go:33:6: exported type FileSysUtilImpl should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/longrunning/deps.go:35:1: exported method FileSysUtilImpl.Exists should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/longrunning/deps.go:39:1: exported method FileSysUtilImpl.MakeDirs should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/longrunning/deps.go:43:1: exported method FileSysUtilImpl.WriteIntoFileWithPermissions should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/longrunning/deps.go:47:1: exported method FileSysUtilImpl.ReadFile should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/longrunning/deps.go:51:1: exported method FileSysUtilImpl.ReadAll should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/longrunning/datastore/datastore.go:41:6: exported type FsStore should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/longrunning/manager/coremodule.go:40:2: comment on exported const Name should be of the form "Name ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/longrunning/manager/coremodule.go:44:2: const NameOfCloudWatchJsonFile should be NameOfCloudWatchJSONFile | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/longrunning/manager/coremodule.go:46:2: comment on exported const NumberOfLongRunningPluginWorkers should be of the form "NumberOfLongRunningPluginWorkers ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/longrunning/manager/coremodule.go:49:2: comment on exported const NumberOfCancelWorkers should be of the form "NumberOfCancelWorkers ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/longrunning/manager/coremodule.go:52:2: comment on exported const PollFrequencyMinutes should be of the form "PollFrequencyMinutes ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/longrunning/manager/coremodule.go:55:2: comment on exported const HardStopTimeout should be of the form "HardStopTimeout ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/longrunning/manager/coremodule.go:58:2: comment on exported const SoftStopTimeout should be of the form "SoftStopTimeout ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/longrunning/manager/coremodule.go:94:2: struct field ec2ConfigXmlParser should be ec2ConfigXMLParser | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/longrunning/manager/coremodule.go:100:1: comment on exported function EnsureInitialization should be of the form "EnsureInitialization ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/longrunning/manager/coremodule.go:126:3: var ec2ConfigXmlParser should be ec2ConfigXMLParser | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/longrunning/manager/coremodule.go:150:9: if block ends with a return statement, so drop this else and outdent its block | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/longrunning/manager/coremodule.go:160:1: comment on exported method Manager.ModuleName should be of the form "ModuleName ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/longrunning/manager/coremodule.go:165:1: comment on exported method Manager.ModuleExecute should be of the form "ModuleExecute ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/longrunning/manager/coremodule.go:225:1: comment on exported method Manager.ModuleRequestStop should be of the form "ModuleRequestStop ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/longrunning/manager/coremodule.go:305:6: var instanceId should be instanceID | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/longrunning/manager/coremodule.go:383:44: func parameter instanceId should be instanceID | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/longrunning/manager/coremodule.go:433:80: func parameter ec2ConfigXmlParser should be ec2ConfigXMLParser | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/longrunning/manager/coremodule_test.go:39:2: var instanceId should be instanceID | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/longrunning/manager/coremodule_test.go:209:2: var mockEc2ConfigXmlParser should be mockEc2ConfigXMLParser | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/longrunning/manager/coremodule_test.go:233:2: var mockEc2ConfigXmlParser should be mockEc2ConfigXMLParser | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/longrunning/manager/coremodule_test.go:253:2: var mockEc2ConfigXmlParser should be mockEc2ConfigXMLParser | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/longrunning/manager/coremodule_test.go:273:2: var mockEc2ConfigXmlParser should be mockEc2ConfigXMLParser | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/longrunning/manager/coremodule_test.go:295:2: var mockEc2ConfigXmlParser should be mockEc2ConfigXMLParser | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/longrunning/manager/coremodule_test.go:323:2: var mockEc2ConfigXmlParser should be mockEc2ConfigXMLParser | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/longrunning/manager/coremodule_test.go:410:6: type MockedEc2ConfigXmlParser should be MockedEc2ConfigXMLParser | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/longrunning/manager/dependencies.go:62:6: var instanceId should be instanceID | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/longrunning/manager/invoke.go:19:1: exported function CreateResult should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/longrunning/manager/invoke.go:34:1: exported function Invoke should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/longrunning/manager/test_coremodule.go:35:7: const CloudWatchId should be CloudWatchID | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/longrunning/manager/test_coremodule.go:61:1: comment on exported method Mock.ModuleName should be of the form "ModuleName ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/longrunning/manager/test_coremodule.go:67:1: comment on exported method Mock.ModuleExecute should be of the form "ModuleExecute ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/longrunning/manager/test_coremodule.go:73:1: comment on exported method Mock.ModuleRequestStop should be of the form "ModuleRequestStop ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/longrunning/plugin/plugin.go:30:6: type name will be used as plugin.PluginState by other packages, and that stutters; consider calling this State | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/longrunning/plugin/plugin.go:37:6: type name will be used as plugin.PluginInfo by other packages, and that stutters; consider calling this Info | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/longrunning/plugin/plugin.go:57:6: type name will be used as plugin.PluginSettings by other packages, and that stutters; consider calling this Settings | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/longrunning/plugin/cloudwatch/config.go:41:6: exported type CloudWatchConfig should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/longrunning/plugin/cloudwatch/config.go:41:6: type name will be used as cloudwatch.CloudWatchConfig by other packages, and that stutters; consider calling this Config | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/longrunning/plugin/cloudwatch/config.go:52:6: type name will be used as cloudwatch.CloudWatchConfigImpl by other packages, and that stutters; consider calling this ConfigImpl | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/longrunning/plugin/cloudwatch/config.go:57:6: exported type EngineConfigurationParser should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/longrunning/plugin/cloudwatch/ec2configxmlparse.go:27:2: exported const EC2ServiceConfigFileName should have comment (or a comment on this block) or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/longrunning/plugin/cloudwatch/ec2configxmlparse.go:31:6: exported type Query should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/longrunning/plugin/cloudwatch/ec2configxmlparse.go:35:6: exported type PluginState should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/longrunning/plugin/cloudwatch/ec2configxmlparse.go:39:6: exported type PluginInfo should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/longrunning/plugin/cloudwatch/ec2configxmlparse.go:45:6: type Ec2ConfigXmlParser should be Ec2ConfigXMLParser | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/longrunning/plugin/cloudwatch/ec2configxmlparse.go:50:6: type Ec2ConfigXmlParserImpl should be Ec2ConfigXMLParserImpl | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/longrunning/plugin/cloudwatch/ec2configxmlparse.go:91:30: error strings should not be capitalized or end with punctuation or a newline | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/longrunning/plugin/cloudwatch/ec2configxmlparse_test.go:32:7: const testCwEnabledEc2ConfigXml should be testCwEnabledEc2ConfigXML | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/longrunning/plugin/cloudwatch/ec2configxmlparse_test.go:33:7: const testCwDisabledEc2ConfigXml should be testCwDisabledEc2ConfigXML | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/longrunning/plugin/cloudwatch/ec2configxmlparse_test.go:34:7: const invalidTestEc2ConfigXml should be invalidTestEc2ConfigXML | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/longrunning/plugin/cloudwatch/ec2configxmlparse_test.go:35:7: const testCwEc2ConfigXmlWithInvalidValue should be testCwEc2ConfigXMLWithInvalidValue | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/longrunning/plugin/cloudwatch/ec2configxmlparse_test.go:36:7: const testCwEc2ConfigXmlWithNoState should be testCwEc2ConfigXMLWithNoState | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/longrunning/plugin/cloudwatch/ec2configxmlparse_test.go:39:2: var ec2ConfigXmlPath should be ec2ConfigXMLPath | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/longrunning/plugin/cloudwatch/ec2configxmlparse_test.go:59:2: var ec2ConfigXmlParser should be ec2ConfigXMLParser | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/longrunning/plugin/cloudwatch/ec2configxmlparse_test.go:85:2: var ec2ConfigXmlParser should be ec2ConfigXMLParser | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/longrunning/plugin/cloudwatch/ec2configxmlparse_test.go:104:2: var ec2ConfigXmlParser should be ec2ConfigXMLParser | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/longrunning/plugin/cloudwatch/ec2configxmlparse_test.go:130:2: var ec2ConfigXmlParser should be ec2ConfigXMLParser | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/longrunning/plugin/cloudwatch/ec2configxmlparse_test.go:156:2: var ec2ConfigXmlParser should be ec2ConfigXMLParser | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/longrunning/plugin/cloudwatch/ec2configxmlparse_test.go:182:2: var ec2ConfigXmlParser should be ec2ConfigXMLParser | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/longrunning/plugin/cloudwatch/ec2configxmlparse_test.go:202:2: var ec2ConfigXmlParser should be ec2ConfigXMLParser | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/longrunning/plugin/cloudwatch/ec2configxmlparse_test.go:242:6: type MockedEc2ConfigXmlParser should be MockedEc2ConfigXMLParser | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/longrunning/plugin/cloudwatch/test_cloudwatch.go:59:1: comment on exported method Mock.Stop should be of the form "Stop ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/longrunning/plugin/cloudwatch/test_cloudwatch.go:71:1: comment on exported method Mock.GetPidOfCloudWatchExe should be of the form "GetPidOfCloudWatchExe ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/longrunning/plugin/rundaemon/rundaemon.go:1:1: package comment should be of the form "Package rundaemon ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/longrunning/plugin/rundaemon/rundaemon.go:34:1: exported function ValidateDaemonInput should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/longrunning/plugin/rundaemon/rundaemon_unix.go:37:1: exported method Plugin.IsRunning should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/longrunning/plugin/rundaemon/rundaemon_unix.go:43:1: exported method Plugin.Start should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/longrunning/plugin/rundaemon/rundaemon_unix.go:49:1: exported method Plugin.Stop should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/managedInstances/auth/rsa_key.go:14:1: package comment should be of the form "Package auth ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/managedInstances/auth/rsa_key.go:35:6: exported type RsaKey should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/managedInstances/auth/rsa_key_test.go:25:11: should omit type string from declaration of var test; it will be inferred from the right-hand side | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/managedInstances/auth/rsa_key_test.go:39:11: should omit type string from declaration of var test; it will be inferred from the right-hand side | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/managedInstances/auth/rsa_key_test.go:40:17: should omit type string from declaration of var testVerify; it will be inferred from the right-hand side | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/managedInstances/auth/rsa_key_test.go:54:11: should omit type string from declaration of var test; it will be inferred from the right-hand side | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/managedInstances/registration/instance_info.go:14:1: package comment should be of the form "Package registration ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/managedInstances/registration/instance_info.go:40:2: exported const RegVaultKey should have comment (or a comment on this block) or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/managedInstances/registration/instance_info.go:129:9: if block ends with a return statement, so drop this else and outdent its block | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/managedInstances/registration/instance_info.go:144:11: should omit type instanceInfo from declaration of var info; it will be inferred from the right-hand side | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/managedInstances/registration/instance_info.go:147:9: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/managedInstances/registration/instance_info_deps.go:14:1: package comment should be of the form "Package registration ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/managedInstances/registration/instance_info_test.go:32:2: var sampleJson should be sampleJSON | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/managedInstances/rolecreds/managedInstances_role_provider_deps.go:14:1: package comment should be of the form "Package rolecreds ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/managedInstances/rolecreds/role_provider.go:1:1: package comment should be of the form "Package rolecreds ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/managedInstances/sharedCredentials/shared_Credentials.go:14:1: package comment should be of the form "Package sharedCredentials ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/managedInstances/sharedCredentials/shared_Credentials_unix.go:16:1: package comment should be of the form "Package sharedCredentials ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/parameterstore/parameterstore.go:35:2: comment on exported const ParamTypeSecureString should be of the form "ParamTypeSecureString ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/parameterstore/parameterstore.go:47:2: comment on exported const StringListDelimiter should be of the form "StringListDelimiter ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/platform/instance_info.go:116:2: var instanceId should be instanceID | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/platform/platform.go:32:6: func name will be used as platform.PlatformName by other packages, and that stutters; consider calling this Name | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/platform/platform.go:37:6: func name will be used as platform.PlatformType by other packages, and that stutters; consider calling this Type | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/platform/platform.go:42:6: func name will be used as platform.PlatformVersion by other packages, and that stutters; consider calling this Version | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/platform/platform.go:47:6: func name will be used as platform.PlatformSku by other packages, and that stutters; consider calling this Sku | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/platform/platform.go:109:24: error strings should not be capitalized or end with punctuation or a newline | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/platform/platform.go:129:1: exported function IsPlatformNanoServer should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/platform/platform_unix.go:44:2: don't use ALL_CAPS in Go names; use CamelCase | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurecontainers/configurecontainers.go:34:2: comment on exported const INSTALL should be of the form "INSTALL ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurecontainers/configurecontainers.go:36:2: exported const UNINSTALL should have comment (or a comment on this block) or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurecontainers/linuxcontainerutil/dep.go:1:1: package comment should be of the form "Package linuxcontainerutil ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurecontainers/linuxcontainerutil/dep_unix.go:27:6: exported type DepLinux should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurecontainers/linuxcontainerutil/dep_unix.go:29:1: exported method DepLinux.GetInstanceContext should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurecontainers/linuxcontainerutil/dep_unix.go:34:1: exported method DepLinux.UpdateUtilExeCommandOutput should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurecontainers/linuxcontainerutil/linuxcontainerutil.go:1:1: package comment should be of the form "Package linuxcontainerutil ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurecontainers/linuxcontainerutil/linuxcontainerutil.go:24:1: exported function RunInstallCommands should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurecontainers/linuxcontainerutil/linuxcontainerutil.go:41:9: if block ends with a return statement, so drop this else and outdent its block | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurecontainers/linuxcontainerutil/linuxcontainerutil.go:158:1: exported function RunUninstallCommands should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurecontainers/linuxcontainerutil/linuxcontainerutil.go:175:9: if block ends with a return statement, so drop this else and outdent its block | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurecontainers/windowscontainerutil/windowscontainerutil.go:31:2: don't use ALL_CAPS in Go names; use CamelCase | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurecontainers/windowscontainerutil/windowscontainerutil.go:31:2: exported const DOCKER_DOWNLOAD_URL should have comment (or a comment on this block) or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurecontainers/windowscontainerutil/windowscontainerutil.go:32:2: don't use ALL_CAPS in Go names; use CamelCase | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurecontainers/windowscontainerutil/windowscontainerutil.go:33:2: don't use ALL_CAPS in Go names; use CamelCase | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurecontainers/windowscontainerutil/windowscontainerutil.go:36:1: exported function RunInstallCommands should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurecontainers/windowscontainerutil/windowscontainerutil.go:54:36: error strings should not be capitalized or end with punctuation or a newline | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurecontainers/windowscontainerutil/windowscontainerutil.go:296:1: exported function RunUninstallCommands should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurecontainers/windowscontainerutil/windowscontainerutil.go:314:36: error strings should not be capitalized or end with punctuation or a newline | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/configurepackage.go:54:6: type name will be used as configurepackage.ConfigurePackagePluginInput by other packages, and that stutters; consider calling this PluginInput | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/configurepackage_lock.go:33:10: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/birdwatcher/birdwatcher.go:43:6: exported type TimeImpl should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/birdwatcher/birdwatcher.go:46:1: exported method TimeImpl.NowUnixNano should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/birdwatcher/birdwatcher.go:99:1: exported method PackageService.PackageServiceName should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/birdwatcher/facade/interface.go:1:1: package comment should be of the form "Package facade ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/birdwatcher/facade/interface.go:1:1: package comment should not have leading space | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/envdetect/envdetect.go:17:6: exported type Collector should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/envdetect/envdetect.go:21:6: exported type CollectorImp should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/envdetect/envdetect_mock.go:8:6: exported type CollectorMock should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/envdetect/envdetect_mock.go:12:1: exported method CollectorMock.CollectData should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/envdetect/constants/constants.go:79:1: comment on exported const SKUProductDatacenterNanoServer should be of the form "SKUProductDatacenterNanoServer ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/envdetect/constants/constants.go:81:7: exported const SKUProductStandardNanoServer should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/envdetect/osdetect/osdetect.go:12:6: exported type OsDetector should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/envdetect/osdetect/darwin/osdetect.go:10:6: exported type Detector should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/envdetect/osdetect/darwin/osdetect.go:13:1: exported method Detector.DetectPkgManager should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/envdetect/osdetect/darwin/osdetect.go:17:1: exported method Detector.DetectInitSystem should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/envdetect/osdetect/darwin/osdetect.go:21:1: exported method Detector.DetectPlatform should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/envdetect/osdetect/linux/osdetect.go:15:6: exported type Detector should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/envdetect/osdetect/linux/osdetect.go:18:1: exported method Detector.DetectPkgManager should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/envdetect/osdetect/linux/osdetect.go:39:1: exported method Detector.DetectInitSystem should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/envdetect/osdetect/linux/osdetect.go:101:1: exported method Detector.DetectPlatform should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/envdetect/osdetect/windows/osdetect.go:13:6: exported type Detector should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/envdetect/osdetect/windows/osdetect.go:18:1: exported method Detector.DetectPkgManager should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/envdetect/osdetect/windows/osdetect.go:22:1: exported method Detector.DetectInitSystem should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/envdetect/osdetect/windows/osdetect.go:26:1: exported method Detector.DetectPlatform should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/envdetect/utils/utils.go:10:1: exported function ReadFileTrim should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/envdetect/utils/utils.go:19:1: exported function ReadFileLines should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/installer/mock/installer.go:16:1: don't use an underscore in package name | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/installer/mock/installer.go:25:6: exported type Mock should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/installer/mock/installer.go:29:1: exported method Mock.Install should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/installer/mock/installer.go:34:1: exported method Mock.Uninstall should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/installer/mock/installer.go:39:1: exported method Mock.Validate should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/installer/mock/installer.go:44:1: exported method Mock.Version should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/installer/mock/installer.go:49:1: exported method Mock.PackageName should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/localpackages/localpackages.go:133:9: if block ends with a return statement, so drop this else and outdent its block | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/localpackages/localpackages.go:249:1: receiver name r should be consistent with previous receiver name repo for localRepository | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/localpackages/localpackages.go:254:1: receiver name r should be consistent with previous receiver name repo for localRepository | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/localpackages/localpackages.go:259:1: receiver name r should be consistent with previous receiver name repo for localRepository | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/localpackages/localpackages.go:375:9: if block ends with a return statement, so drop this else and outdent its block | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/localpackages/localpackages.go:383:9: if block ends with a return statement, so drop this else and outdent its block | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/localpackages/localpackages_deps.go:25:1: comment on exported type FileSysDep should be of the form "FileSysDep ..." (with optional leading article) | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/localpackages/localpackages_test.go:513:2: var initialJson should be initialJSON | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/localpackages/mock/repository_mock.go:16:1: don't use an underscore in package name | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/localpackages/mock/repository_mock.go:28:6: exported type MockedRepository should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/localpackages/mock/repository_mock.go:32:1: exported method MockedRepository.GetInstalledVersion should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/localpackages/mock/repository_mock.go:37:1: exported method MockedRepository.ValidatePackage should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/localpackages/mock/repository_mock.go:42:1: exported method MockedRepository.RefreshPackage should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/localpackages/mock/repository_mock.go:47:1: exported method MockedRepository.AddPackage should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/localpackages/mock/repository_mock.go:52:1: exported method MockedRepository.SetInstallState should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/localpackages/mock/repository_mock.go:57:1: exported method MockedRepository.GetInstallState should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/localpackages/mock/repository_mock.go:62:1: exported method MockedRepository.RemovePackage should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/localpackages/mock/repository_mock.go:67:1: exported method MockedRepository.GetInventoryData should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/localpackages/mock/repository_mock.go:72:1: exported method MockedRepository.GetInstaller should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/localpackages/mock/repository_mock.go:80:1: exported method MockedRepository.ReadManifest should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/localpackages/mock/repository_mock.go:85:1: exported method MockedRepository.WriteManifest should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/packageservice/cache.go:32:1: exported function ManifestCacheMemNew should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/packageservice/cache.go:36:1: exported method ManifestCacheMem.CacheKey should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/packageservice/cache.go:40:1: exported method ManifestCacheMem.ReadManifest should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/packageservice/cache.go:44:1: exported method ManifestCacheMem.WriteManifest should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/packageservice/packageservice.go:52:2: don't use underscores in Go names; const PackageServiceName_ssms3 should be PackageServiceNameSsms3 | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/packageservice/packageservice.go:52:2: exported const PackageServiceName_ssms3 should have comment (or a comment on this block) or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/packageservice/packageservice.go:53:2: don't use underscores in Go names; const PackageServiceName_birdwatcher should be PackageServiceNameBirdwatcher | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/packageservice/utils.go:1:1: package comment should be of the form "Package packageservice ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/packageservice/utils.go:20:7: exported const Latest should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/packageservice/utils.go:22:1: exported function IsLatest should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/packageservice/mock/packageservice.go:15:1: don't use an underscore in package name | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/packageservice/mock/packageservice.go:23:6: exported type Mock should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/packageservice/mock/packageservice.go:27:1: exported method Mock.PackageServiceName should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/packageservice/mock/packageservice.go:32:1: exported method Mock.DownloadManifest should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/packageservice/mock/packageservice.go:37:1: exported method Mock.DownloadArtifact should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/packageservice/mock/packageservice.go:42:1: exported method Mock.ReportResult should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/ssminstaller/ssminstaller.go:36:6: exported type Installer should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/ssminstaller/ssminstaller.go:46:6: exported type ActionType should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/ssminstaller/ssminstaller.go:49:2: don't use ALL_CAPS in Go names; use CamelCase | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/ssminstaller/ssminstaller.go:49:2: exported const ACTION_TYPE_JSON should have comment (or a comment on this block) or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/ssminstaller/ssminstaller.go:50:2: don't use ALL_CAPS in Go names; use CamelCase | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/ssminstaller/ssminstaller.go:51:2: don't use ALL_CAPS in Go names; use CamelCase | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/ssminstaller/ssminstaller.go:54:6: exported type Action should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/ssminstaller/ssminstaller.go:60:1: exported function New should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/ssminstaller/ssminstaller.go:76:1: exported method Installer.Install should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/ssminstaller/ssminstaller.go:80:1: exported method Installer.Uninstall should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/ssminstaller/ssminstaller.go:84:1: exported method Installer.Validate should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/ssminstaller/ssminstaller.go:88:1: exported method Installer.Version should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/ssminstaller/ssminstaller.go:92:1: exported method Installer.PackageName should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/ssminstaller/ssminstaller.go:198:24: method readJsonAction should be readJSONAction | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/ssminstaller/ssminstaller.go:210:2: var actionJson should be actionJSON | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/ssminstaller/ssminstaller.go:251:2: var actionPathJson should be actionPathJSON | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/ssminstaller/ssminstaller.go:255:2: var actionPathExistsJson should be actionPathExistsJSON | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/ssminstaller/ssminstaller.go:261:3: should replace countExists += 1 with countExists++ | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/ssminstaller/ssminstaller.go:267:3: should replace countExists += 1 with countExists++ | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/ssminstaller/ssminstaller.go:273:3: should replace countExists += 1 with countExists++ | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/ssminstaller/ssminstaller.go:358:9: if block ends with a return statement, so drop this else and outdent its block | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/ssminstaller/ssminstaller_test.go:53:124: func parameter contentJson should be contentJSON | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/ssminstaller/ssminstaller_test.go:77:96: func parameter contentJson should be contentJSON | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/ssminstaller/ssminstaller_test.go:99:103: func parameter contentJson should be contentJSON | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/ssminstaller/ssminstaller_test.go:156:92: func parameter existJson should be existJSON | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/ssms3/ssms3.go:68:2: exported const ActiveServiceURLBeta should have comment (or a comment on this block) or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/ssms3/ssms3.go:72:6: exported type PackageService should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/ssms3/ssms3.go:95:1: exported function New should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/ssms3/ssms3.go:111:1: exported method PackageService.PackageServiceName should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/ssms3/ssms3.go:137:1: exported method PackageService.DownloadArtifact should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/ssms3/ssms3.go:142:1: exported method PackageService.ReportResult should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/ssms3/ssms3_mock.go:24:1: comment on exported type SSMS3Mock should be of the form "SSMS3Mock ..." (with optional leading article) | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/ssms3/ssms3_mock.go:25:6: type name will be used as ssms3.SSMS3Mock by other packages, and that stutters; consider calling this Mock | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/ssms3/ssms3_mock.go:29:1: exported method SSMS3Mock.ListS3Folders should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/ssms3/ssms3_mock.go:34:1: exported method SSMS3Mock.CanGetS3Object should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/ssms3/ssms3_mock.go:39:1: exported method SSMS3Mock.Download should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/trace/trace.go:32:6: exported type TimeImpl should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/trace/trace.go:35:1: exported method TimeImpl.NowUnixNano should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/trace/trace.go:39:6: exported type Trace should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/trace/trace.go:75:1: exported function NewTracer should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/trace/trace.go:173:9: if block ends with a return statement, so drop this else and outdent its block | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/trace/trace.go:208:1: comment on exported method Trace.WithError should be of the form "WithError ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/trace/trace.go:265:1: exported method Trace.AppendWithSubtraces should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/trace/trace_pluginoutput.go:1:1: package comment should be of the form "Package trace ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/trace/trace_pluginoutput.go:21:6: exported type PluginOutputTrace should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/trace/trace_pluginoutput.go:29:1: exported method PluginOutputTrace.GetStatus should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/trace/trace_pluginoutput.go:30:1: exported method PluginOutputTrace.GetExitCode should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/trace/trace_pluginoutput.go:31:1: exported method PluginOutputTrace.GetStdout should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/trace/trace_pluginoutput.go:32:1: exported method PluginOutputTrace.GetStderr should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/trace/trace_pluginoutput.go:34:1: exported method PluginOutputTrace.SetStatus should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/trace/trace_pluginoutput.go:35:1: exported method PluginOutputTrace.SetExitCode should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/trace/trace_pluginoutput.go:39:1: exported method PluginOutputTrace.MarkAsFailed should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/trace/trace_pluginoutput.go:51:1: exported method PluginOutputTrace.MarkAsSucceeded should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/trace/trace_pluginoutput.go:51:1: receiver name out should be consistent with previous receiver name po for PluginOutputTrace | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/trace/trace_pluginoutput.go:56:1: exported method PluginOutputTrace.MarkAsInProgress should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/trace/trace_pluginoutput.go:56:1: receiver name out should be consistent with previous receiver name po for PluginOutputTrace | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/trace/trace_pluginoutput.go:61:1: exported method PluginOutputTrace.MarkAsSuccessWithReboot should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/trace/trace_pluginoutput.go:61:1: receiver name out should be consistent with previous receiver name po for PluginOutputTrace | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/trace/trace_pluginoutput.go:66:1: exported method PluginOutputTrace.MarkAsCancelled should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/trace/trace_pluginoutput.go:66:1: receiver name out should be consistent with previous receiver name po for PluginOutputTrace | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/trace/trace_pluginoutput.go:71:1: exported method PluginOutputTrace.MarkAsShutdown should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/trace/trace_pluginoutput.go:71:1: receiver name out should be consistent with previous receiver name po for PluginOutputTrace | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/trace/trace_pluginoutput.go:76:1: receiver name out should be consistent with previous receiver name po for PluginOutputTrace | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/trace/trace_pluginoutput.go:83:1: exported method PluginOutputTrace.AppendInfo should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/trace/trace_pluginoutput.go:87:1: exported method PluginOutputTrace.AppendInfof should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/trace/trace_pluginoutput.go:91:1: exported method PluginOutputTrace.AppendError should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/trace/trace_pluginoutput.go:95:1: exported method PluginOutputTrace.AppendErrorf should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/trace/mock/trace.go:15:1: don't use an underscore in package name | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/trace/mock/trace.go:24:6: exported type Mock should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/trace/mock/trace.go:28:1: exported method Mock.BeginSection should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/trace/mock/trace.go:33:1: exported method Mock.EndSection should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/trace/mock/trace.go:38:1: exported method Mock.AddTrace should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/trace/mock/trace.go:42:1: exported method Mock.Traces should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/trace/mock/trace.go:47:1: exported method Mock.CurrentTrace should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/trace/mock/trace.go:52:1: exported method Mock.ToPackageServiceTrace should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/trace/mock/trace.go:57:1: exported method Mock.ToPluginOutput should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/dockercontainer/dockercontainer.go:37:2: comment on exported const CREATE should be of the form "CREATE ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/dockercontainer/dockercontainer.go:39:2: exported const START should have comment (or a comment on this block) or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/dockercontainer/dockercontainer.go:53:2: don't use ALL_CAPS in Go names; use CamelCase | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/dockercontainer/dockercontainer.go:53:2: exported const ACTION_REQUIRES_PARAMETER should have comment (or a comment on this block) or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/dockercontainer/dockercontainer.go:57:5: don't use underscores in Go names; var duration_Seconds should be durationSeconds | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/dockercontainer/dockercontainer.go:57:5: var duration_Seconds is of type time.Duration; don't use unit-specific suffix "Seconds" | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/dockercontainer/dockercontainer.go:57:22: should omit type time.Duration from declaration of var duration_Seconds; it will be inferred from the right-hand side | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/dockercontainer/dockercontainer.go:65:6: type name will be used as dockercontainer.DockerContainerPluginInput by other packages, and that stutters; consider calling this PluginInput | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/dockercontainer/dockercontainer.go:75:2: struct field CpuShares should be CPUShares | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/dockercontainer/dockercontainer.go:178:18: should omit type string from declaration of var commandName; it will be inferred from the right-hand side | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/dockercontainer/dockercontainer.go:396:2: var validCpuSharesValue should be validCPUSharesValue | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/inventory/inventory.go:506:18: method ParseAssociationIdFromFileName should be ParseAssociationIDFromFileName | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/inventory/inventory.go:575:13: var extraAssociationId should be extraAssociationID | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/inventory/datauploader/optimizer.go:56:1: exported function NewOptimizerImpl should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/inventory/datauploader/optimizer.go:60:1: exported function NewOptimizerImplWithLocation should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/inventory/datauploader/optimizer.go:100:1: exported method Impl.UpdateContentHash should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/inventory/datauploader/optimizer.go:117:1: exported method Impl.GetContentHash should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/inventory/datauploader/test_optimizer.go:21:1: comment on exported type MockOptinizer should be of the form "MockOptinizer ..." (with optional leading article) | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/inventory/datauploader/test_optimizer.go:26:1: exported function NewMockDefault should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/inventory/datauploader/test_optimizer.go:31:1: exported method MockOptinizer.UpdateContentHash should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/inventory/datauploader/test_optimizer.go:36:1: exported method MockOptinizer.GetContentHash should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/inventory/datauploader/utility.go:60:20: error strings should not be capitalized or end with punctuation or a newline | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/inventory/gatherers/application/dataProvider.go:104:21: error strings should not be capitalized or end with punctuation or a newline | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/inventory/gatherers/application/dataProvider.go:122:6: func convertEntriesToJsonArray should be convertEntriesToJSONArray | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/inventory/gatherers/application/dataProvider_test.go:167:4: should replace index += 1 with index++ | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/inventory/gatherers/custom/customGatherer.go:145:16: error strings should not be capitalized or end with punctuation or a newline | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/inventory/gatherers/custom/customGatherer.go:327:20: error strings should not be capitalized or end with punctuation or a newline | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/inventory/gatherers/file/dataProvider.go:31:7: exported const FileCountLimit should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/inventory/gatherers/file/dataProvider.go:32:7: exported const FileCountLimitExceeded should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/inventory/gatherers/file/dataProvider.go:103:28: error strings should not be capitalized or end with punctuation or a newline | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/inventory/gatherers/file/dataProvider.go:141:20: error strings should not be capitalized or end with punctuation or a newline | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/inventory/gatherers/file/fileGatherer.go:18:6: exported type T should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/inventory/gatherers/instancedetailedinformation/dataProvider_test.go:34:4: should replace index += 1 with index++ | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/inventory/model/model.go:38:2: comment on exported const Arch64Bit should be of the form "Arch64Bit ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/inventory/model/model.go:40:2: comment on exported const Arch32Bit should be of the form "Arch32Bit ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/inventory/model/model.go:65:2: struct field InstanceId should be InstanceID | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/inventory/model/model.go:67:2: struct field IpAddress should be IPAddress | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/inventory/model/model.go:74:2: exported const AWSComponent should have comment (or a comment on this block) or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/inventory/model/model.go:87:2: struct field PackageId should be PackageID | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/inventory/model/model.go:122:2: struct field HotFixId should be HotFixID | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/inventory/model/model.go:205:9: if block ends with a return statement, so drop this else and outdent its block | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/lrpminvoker/invoker.go:81:5: var configJson should be configJSON | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/pluginutil/pluginutil.go:326:21: error strings should not be capitalized or end with punctuation or a newline | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/pluginutil/pluginutil_test.go:130:6: var outUrl should be outURL | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/pluginutil/pluginutil_test.go:132:2: var defaultProxyUrl should be defaultProxyURL | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/pluginutil/pluginutil_unix.go:29:5: exported var ShellCommand should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/pluginutil/pluginutil_unix.go:30:5: exported var ShellArgs should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/pluginutil/pluginutil_unix.go:52:1: exported function GetShellCommand should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/pluginutil/pluginutil_unix.go:56:1: exported function GetShellArguments should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/pluginutil/pluginutil_unix.go:60:1: exported function LocalRegistryKeyGetStringsValue should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/pluginutil/pluginutil_unix.go:61:28: error strings should not be capitalized or end with punctuation or a newline | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/refreshassociation/refreshassociation.go:36:6: type name will be used as refreshassociation.RefreshAssociationPluginInput by other packages, and that stutters; consider calling this PluginInput | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/runscript/runpowershellscript.go:35:68: exported func NewRunPowerShellPlugin returns unexported type *runscript.runPowerShellPlugin, which can be annoying to use | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/runscript/runscript.go:48:6: type name will be used as runscript.RunScriptPluginInput by other packages, and that stutters; consider calling this PluginInput | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/runscript/runscript.go:56:1: exported method Plugin.AssignPluginConfigs should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/runscript/runshellscript.go:35:74: exported func NewRunShellPlugin returns unexported type *runscript.runShellPlugin, which can be annoying to use | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/updatessmagent/updateagent.go:483:6: var manifestUrl should be manifestURL | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/rebooter/rebooter.go:19:6: exported type RebootType should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/rebooter/rebooter.go:22:2: exported const RebootRequestTypeReboot should have comment (or a comment on this block) or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/rebooter/rebooter.go:28:1: exported function GetChannel should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/rebooter/rebooter.go:41:1: exported function RequestPendingReboot should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/rebooter/rebooter_test.go:36:25: should drop = 0 from declaration of var successCount; it is the zero value | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/runcommand/coremodule.go:50:1: comment on exported method RunCommandService.ModuleName should be of the form "ModuleName ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/runcommand/coremodule.go:55:1: comment on exported method RunCommandService.ModuleExecute should be of the form "ModuleExecute ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/runcommand/coremodule.go:88:1: exported method RunCommandService.ModuleRequestStop should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/runcommand/reply.go:26:1: comment on exported function FormatPayload should be of the form "FormatPayload ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/runcommand/scheduler.go:26:21: should omit type map[string]time.Time from declaration of var lastPollTimeMap; it will be inferred from the right-hand side | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/runcommand/service.go:51:2: comment on exported const CancelCommandTopicPrefixOffline should be of the form "CancelCommandTopicPrefixOffline ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/runcommand/service.go:54:2: exported const CancelWorkersLimit should have comment (or a comment on this block) or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/runcommand/service.go:72:6: exported type ExecuterCreator should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/runcommand/service.go:76:6: exported type SendResponse should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/runcommand/service.go:78:1: comment on exported type RunCommandService should be of the form "RunCommandService ..." (with optional leading article) | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/runcommand/service.go:79:6: type name will be used as runcommand.RunCommandService by other packages, and that stutters; consider calling this Service | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/runcommand/service.go:96:1: comment on exported function NewOfflineService should be of the form "NewOfflineService ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/runcommand/service.go:110:1: comment on exported function NewMDSService should be of the form "NewMDSService ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/runcommand/service.go:119:1: comment on exported function NewService should be of the form "NewService ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/runcommand/service_test.go:43:5: var testMessageId should be testMessageID | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/runcommand/service_test.go:369:3: var pluginId should be pluginID | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/runcommand/utils.go:173:6: var parsedContentJson should be parsedContentJSON | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/runcommand/utils.go:219:12: should omit 2nd value from range; this loop is equivalent to `for name := range ...` | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/runcommand/mds/offlineservice.go:77:3: var requestUuid should be requestUUID | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/runcommand/mds/offlineservice.go:143:10: if block ends with a return statement, so drop this else and outdent its block | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/runcommand/mds/offlineservice_test.go:95:9: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/s3util/riputil.go:43:1: comment on exported function GetS3Endpoint should be of the form "GetS3Endpoint ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/s3util/riputil.go:65:1: comment on exported function GetS3GenericEndPoint should be of the form "GetS3GenericEndPoint ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/s3util/s3uri.go:30:2: comment on exported const ChinaRegionPrefix should be of the form "ChinaRegionPrefix ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/s3util/s3util.go:40:6: exported type IAmazonS3Util should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/s3util/s3util.go:46:6: exported type AmazonS3Util should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/s3util/s3util.go:50:1: exported function NewAmazonS3Util should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/s3util/s3util.go:114:1: comment on exported function GetBucketRegion should be of the form "GetBucketRegion ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/s3util/s3util.go:127:9: if block ends with a return statement, so drop this else and outdent its block | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/s3util/s3util.go:132:1: comment on exported function GetS3Header should be of the form "GetS3Header ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/s3util/s3util.go:179:8: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/s3util/s3util_dep.go:21:6: exported type HttpProvider should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/s3util/s3util_dep.go:21:6: type HttpProvider should be HTTPProvider | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/s3util/s3util_dep.go:26:6: type HttpProviderImpl should be HTTPProviderImpl | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/s3util/s3util_dep.go:28:1: exported method HttpProviderImpl.Head should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/s3util/s3util_test.go:24:2: var mockHttpProvider should be mockHTTPProvider | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/s3util/s3util_test.go:40:2: var mockHttpProvider should be mockHTTPProvider | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/s3util/s3util_test.go:60:2: var mockHttpProvider should be mockHTTPProvider | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/s3util/s3util_test.go:81:2: var mockHttpProvider should be mockHTTPProvider | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/s3util/s3util_test.go:98:2: var mockHttpProvider should be mockHTTPProvider | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/s3util/s3util_test.go:108:6: type MockedHttpProvider should be MockedHTTPProvider | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/s3util/generator/riputil-gen.go:41:5: var ripConfigJsonFilePath should be ripConfigJSONFilePath | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/s3util/generator/riputil-gen.go:113:1: comment on exported type AutoGeneratedRipConfigSchema should be of the form "AutoGeneratedRipConfigSchema ..." (with optional leading article) | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/sdkutil/retryer/retryer.go:27:6: exported type SsmRetryer should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/ssm/service.go:50:3: interface method parameter executionId should be executionID | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/ssm/service.go:51:3: interface method parameter instanceId should be instanceID | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/ssm/service.go:171:2: method parameter executionId should be executionID | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/ssm/service.go:172:2: method parameter instanceId should be instanceID | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/ssm/test_service.go:136:1: comment on exported method Mock.PutComplianceItems should be of the form "PutComplianceItems ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/ssm/test_service.go:141:2: method parameter executionId should be executionID | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/ssm/test_service.go:142:2: method parameter instanceId should be instanceID | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/ssm/rsaauth/rsa_service.go:38:20: func parameter serverId should be serverID | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/ssm/util/util.go:28:1: exported function AwsConfig should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/startup/startup.go:43:1: comment on exported method Processor.ModuleName should be of the form "ModuleName ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/startup/startup.go:48:1: comment on exported method Processor.ModuleExecute should be of the form "ModuleExecute ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/startup/startup.go:62:1: comment on exported method Processor.ModuleRequestStop should be of the form "ModuleRequestStop ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/startup/serialport/serialport_unix.go:34:6: exported type SerialPort should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/startup/serialport/serialport_unix.go:82:1: exported method SerialPort.OpenPort should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/task/test_task.go:52:1: comment on exported method MockedPool.HasJob should be of the form "HasJob ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/task/test_task.go:84:1: exported method MockCancelFlag.Set should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/task/test_task.go:88:1: exported method MockCancelFlag.State should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/update/processor/context.go:183:2: redundant if ...; err != nil check, just return error instead. | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/update/processor/progress.go:120:2: redundant if ...; err != nil check, just return error instead. | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/update/updater/updater.go:168:2: redundant if ...; err != nil check, just return error instead. | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/updateutil/updateutil.go:98:2: comment on exported const PlatformSuseOS should be of the form "PlatformSuseOS ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/updateutil/updateutil.go:101:2: comment on exported const PlatformRaspbian should be of the form "PlatformRaspbian ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/updateutil/updateutil.go:349:1: comment on exported method Utility.ExeCommandOutput should be of the form "ExeCommandOutput ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/updateutil/updateutil.go:621:1: exported function CompareVersion should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/updateutil/updateutil_test.go:135:18: should drop = nil from declaration of var err; it is the zero value | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/user/user.go:14:1: package comment should be of the form "Package user ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/user/user_unix.go:16:1: package comment should be of the form "Package user ..." | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/user/user_unix.go:31:2: don't use ALL_CAPS in Go names; use CamelCase | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/user/user_unix.go:31:2: exported const PASSWD_PATH should have comment (or a comment on this block) or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/user/user_unix.go:32:2: don't use ALL_CAPS in Go names; use CamelCase | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/user/user_unix.go:34:2: don't use ALL_CAPS in Go names; use CamelCase | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/user/user_unix.go:35:2: don't use ALL_CAPS in Go names; use CamelCase | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/user/user_unix.go:36:2: don't use ALL_CAPS in Go names; use CamelCase | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/user/user_unix.go:37:2: don't use ALL_CAPS in Go names; use CamelCase | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/user/user_unix.go:38:2: don't use ALL_CAPS in Go names; use CamelCase | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/user/user_unix.go:49:15: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/user/user_unix.go:77:2: don't use underscores in Go names; var parsed_str should be parsedStr | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/vault/vault.go:17:6: exported type Vault should have comment or be unexported | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/vault/fsvault/dep.go:54:6: type fsvJsonHandler should be fsvJSONHandler | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/vault/fsvault/dep_test.go:65:6: type fsvJsonHandlerMock should be fsvJSONHandlerMock | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/vault/fsvault/fsvault.go:27:19: should omit type map[string]string from declaration of var manifest; it will be inferred from the right-hand side | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/vault/fsvault/fsvault.go:28:19: should omit type bool from declaration of var initialized; it will be inferred from the right-hand side | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/vault/fsvault/fsvault.go:29:19: should omit type string from declaration of var vaultFolderPath; it will be inferred from the right-hand side | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/vault/fsvault/fsvault.go:30:19: should omit type string from declaration of var manifestFilePath; it will be inferred from the right-hand side | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/vault/fsvault/fsvault.go:31:19: should omit type string from declaration of var storeFolderPath; it will be inferred from the right-hand side | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/vault/fsvault/fsvault.go:47:21: error strings should not be capitalized or end with punctuation or a newline | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/vault/fsvault/fsvault.go:53:21: error strings should not be capitalized or end with punctuation or a newline | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/vault/fsvault/fsvault.go:72:26: error strings should not be capitalized or end with punctuation or a newline | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/vault/fsvault/fsvault.go:76:26: error strings should not be capitalized or end with punctuation or a newline | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/vault/fsvault/fsvault.go:105:20: error strings should not be capitalized or end with punctuation or a newline | |
Run 'go vet' | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/birdwatcher/birdwatcher_test.go:204: osdetect.OperatingSystem composite literal uses unkeyed fields | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/birdwatcher/birdwatcher_test.go:287: osdetect.OperatingSystem composite literal uses unkeyed fields | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/birdwatcher/birdwatcher_test.go:288: ec2infradetect.Ec2Infrastructure composite literal uses unkeyed fields | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/birdwatcher/birdwatcher_test.go:379: osdetect.OperatingSystem composite literal uses unkeyed fields | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/birdwatcher/birdwatcher_test.go:380: ec2infradetect.Ec2Infrastructure composite literal uses unkeyed fields | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/birdwatcher/birdwatcher_test.go:463: osdetect.OperatingSystem composite literal uses unkeyed fields | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/birdwatcher/birdwatcher_test.go:464: ec2infradetect.Ec2Infrastructure composite literal uses unkeyed fields | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/birdwatcher/birdwatcher_test.go:616: osdetect.OperatingSystem composite literal uses unkeyed fields | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/birdwatcher/birdwatcher_test.go:617: ec2infradetect.Ec2Infrastructure composite literal uses unkeyed fields | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/ssminstaller/ssminstaller_test.go:73: osdetect.OperatingSystem composite literal uses unkeyed fields | |
/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/agent/plugins/configurepackage/ssminstaller/ssminstaller_test.go:74: ec2infradetect.Ec2Infrastructure composite literal uses unkeyed fields | |
makefile:39: recipe for target 'checkstyle' failed | |
make: *** [checkstyle] Error 1 | |
mkdir -p /home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/bin/prepacked/linux_amd64 | |
cp -p /home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/bin/linux_amd64/amazon-ssm-agent /home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/bin/prepacked/linux_amd64/amazon-ssm-agent | |
cp: cannot stat '/home/ubuntu/sandbox/amazon-ssm-agent/parts/ssm-agent/go/src/github.com/aws/amazon-ssm-agent/bin/linux_amd64/amazon-ssm-agent': No such file or directory | |
makefile:217: recipe for target 'prepack-linux' failed | |
make: *** [prepack-linux] Error 1 | |
mv: cannot stat 'bin/prepacked/linux_amd64/*': No such file or directory | |
Traceback (most recent call last): | |
File "/usr/bin/snapcraft", line 9, in <module> | |
load_entry_point('snapcraft==2.34', 'console_scripts', 'snapcraft')() | |
File "/usr/lib/python3/dist-packages/pkg_resources/__init__.py", line 542, in load_entry_point | |
return get_distribution(dist).load_entry_point(group, name) | |
File "/usr/lib/python3/dist-packages/pkg_resources/__init__.py", line 2569, in load_entry_point | |
return ep.load() | |
File "/usr/lib/python3/dist-packages/pkg_resources/__init__.py", line 2229, in load | |
return self.resolve() | |
File "/usr/lib/python3/dist-packages/pkg_resources/__init__.py", line 2235, in resolve | |
module = __import__(self.module_name, fromlist=['__name__'], level=0) | |
File "/usr/lib/python3/dist-packages/snapcraft/cli/__main__.py", line 19, in <module> | |
run(prog_name='snapcraft') | |
File "/usr/lib/python3/dist-packages/click/core.py", line 716, in __call__ | |
return self.main(*args, **kwargs) | |
File "/usr/lib/python3/dist-packages/click/core.py", line 696, in main | |
rv = self.invoke(ctx) | |
File "/usr/lib/python3/dist-packages/click/core.py", line 1037, in invoke | |
return Command.invoke(self, ctx) | |
File "/usr/lib/python3/dist-packages/click/core.py", line 889, in invoke | |
return ctx.invoke(self.callback, **ctx.params) | |
File "/usr/lib/python3/dist-packages/click/core.py", line 534, in invoke | |
return callback(*args, **kwargs) | |
File "/usr/lib/python3/dist-packages/click/decorators.py", line 17, in new_func | |
return f(get_current_context(), *args, **kwargs) | |
File "/usr/lib/python3/dist-packages/snapcraft/cli/__init__.py", line 110, in run | |
ctx.forward(lifecyclecli.commands['snap']) | |
File "/usr/lib/python3/dist-packages/click/core.py", line 552, in forward | |
return self.invoke(cmd, **kwargs) | |
File "/usr/lib/python3/dist-packages/click/core.py", line 534, in invoke | |
return callback(*args, **kwargs) | |
File "/usr/lib/python3/dist-packages/snapcraft/cli/lifecycle.py", line 132, in snap | |
project_options, directory=directory, output=output) | |
File "/usr/lib/python3/dist-packages/snapcraft/internal/lifecycle.py", line 349, in snap | |
execute('prime', project_options) | |
File "/usr/lib/python3/dist-packages/snapcraft/internal/lifecycle.py", line 130, in execute | |
_Executor(config, project_options).run(step, part_names) | |
File "/usr/lib/python3/dist-packages/snapcraft/internal/lifecycle.py", line 225, in run | |
self._run_step(step, part, part_names) | |
File "/usr/lib/python3/dist-packages/snapcraft/internal/lifecycle.py", line 262, in _run_step | |
getattr(part, step)() | |
File "/usr/lib/python3/dist-packages/snapcraft/internal/pluginhandler/__init__.py", line 328, in build | |
script_runner.run(scriptlet=build_scriptlet) | |
File "/usr/lib/python3/dist-packages/snapcraft/internal/pluginhandler/_scriptlets.py", line 43, in run | |
run([scriptlet_path], cwd=self._builddir) | |
File "/usr/lib/python3/dist-packages/snapcraft/internal/common.py", line 63, in run | |
subprocess.check_call(['/bin/sh', f.name] + cmd, **kwargs) | |
File "/usr/lib/python3.5/subprocess.py", line 581, in check_call | |
raise CalledProcessError(retcode, cmd) | |
subprocess.CalledProcessError: Command '['/bin/sh', '/tmp/tmpqnjeuk6h', '/tmp/tmpobxrkdng']' returned non-zero exit status 1 | |
ubuntu@ip-10-0-0-244:~/sandbox/amazon-ssm-agent$ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment