Skip to content

Instantly share code, notes, and snippets.

@davidwasamrf
Last active November 24, 2016 09:00
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save davidwasamrf/b676173688ebf02da92b6fdfa9a9f769 to your computer and use it in GitHub Desktop.
Save davidwasamrf/b676173688ebf02da92b6fdfa9a9f769 to your computer and use it in GitHub Desktop.
  • cache adNetwork results (maybe keep cache life longer because will not change && small because 1 per tenant < 400) SEE WITH TOMAS

  • unify AdConfiguration with TwisterAdNetwork

  • see how to create a twister.json that could be merged with our twisterConfig.json -> empty twister.json in marfeel tenant as default -> if one adNetwork screw up, we put a twister.json in tenant directory; it can overwrite stuff so one adNetwork is removed or replaced or add a new add network for test purpose quick quick

  • implement share_for_customer as soon as insight implements it for 1 ad per page

  • review TODOs before merging with master

  • create branch to work together

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment