Skip to content

Instantly share code, notes, and snippets.

@davidyell
Created May 18, 2017 11:32
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save davidyell/071149cdad55272ddcf2612332ab6137 to your computer and use it in GitHub Desktop.
Save davidyell/071149cdad55272ddcf2612332ab6137 to your computer and use it in GitHub Desktop.
Open source workflow etiquette
Neon1024: What is the accepted way to get lots of changes which are dependant into a repo?
Neon1024: I’ve got an open PR
Neon1024: I now need to add another feature which relies on that PR
Neon1024: Do I branch from my PR branch
Neon1024: Is it bad etiquette to just fork the repo, make all my changes and then offer a huge pr?
Neon1024: Well, like, not bad etiquette, but I mean, like it’d be super hard to review right?
Neon1024: But would dependant Pr’s be as confusing?
Neon1024: I want to solve this, https://github.com/UseMuffin/Webservice/issues/41
Neon1024: But I need this merged, https://github.com/UseMuffin/Webservice/pull/38
Neon1024: Which in turn has to have this merged before it, https://github.com/UseMuffin/Webservice/pull/39
Neon1024: I’m building stuff on the plugin at work currently, so I can see a point where not having this stuff in the plugin will block progress
Neon1024: Hence I think a fork might be a better idea
Neon1024: Perhaps i could fork it
Neon1024: Make a branch for all my changes
Neon1024: Keep the upstream and then just preserve my changes in their own topic branches
Neon1024: Then I could keep my master up to date, and submit PR’s from the branches to the upstream
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment