Last active
April 9, 2018 08:10
-
-
Save dbismut/2f58e4d33924558f7c5473b21715851e to your computer and use it in GitHub Desktop.
Part 3 - Fixes close icon fixed position after entering transition
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
executeEnteringTransition = (node, done) => { | |
/* same code */ | |
complete: () => { | |
tween({ from: windowScroll.get('top'), to: 0 }).start({ | |
update: v => windowScroll.set('top', v), | |
complete: () => { | |
// this removes all style from the post node | |
// and fixes the close icon position bug | |
// https://stackoverflow.com/questions/42660332/css-transform-parent-and-fixed-child-is-there-a-way-to-breakout-of-node-with-tr | |
this.post.style = null; | |
done(); | |
} | |
}); | |
} | |
}); | |
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment