Skip to content

Instantly share code, notes, and snippets.

@dcramer
Last active December 14, 2015 20:49
Show Gist options
  • Star 2 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save dcramer/5146800 to your computer and use it in GitHub Desktop.
Save dcramer/5146800 to your computer and use it in GitHub Desktop.
Code Review Quality/Performance Indicators

Questions to answer:

  • Is it a productivity hit?
  • What happens when only new hires are required to do code review?
  • How bad at large patches?
  • What about lack of automated tests?
  • Does a lot of back and forth (e.g. comments) indicate problems?
  • Does assigning more people (or less) to reviews improve anything?
  • How does a person spending more time committing (vs reviewing) affect the team?

Things to measure:

  • Duration review was open
  • Final outcome of review (abandoned, landed)
  • Did the patch contain tests
  • Number of reviewers
  • Size of patch
  • Time blocked (e.g. waiting on another individual)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment