Skip to content

Instantly share code, notes, and snippets.

@dcsg
Last active December 31, 2015 03:28
Show Gist options
  • Save dcsg/7927443 to your computer and use it in GitHub Desktop.
Save dcsg/7927443 to your computer and use it in GitHub Desktop.
SymfonyCon Hacking Day

Me and Luis Cordova have setup some guidelines for SymfonyCon Hacking Day.

We selected some tickets you can pick: https://docs.google.com/spreadsheet/ccc?key=0Ao1MtzhUynSNdE1HMVlpZV9DdHhxdGp0ZHc5Y0hpdEE&usp=drive_web#gid=3

  1. Process to create a Pull Request

    • Fork the repository
    • checkout the right branch
    • reproduce the bug and create the failing test
    • Fix the bug and make sure the tests are passing
    • Run tests locally
    • Create PR to the branch you worked on and don’t forget to mention the original bug issue number
  2. Process to reproduce bugs

    • Fork the repository standard edition repo
    • checkout the right branch
    • reproduce the bug
    • create a new branch with the code to reproduce the bug and create the failing test
    • Branch name convention <issue_number>
    • Create PR to the branch you worked on and don’t forget to mention the original bug issue number

Links for documentation:

@dlondero
Copy link

I would suggest to create tests BEFORE fixing the bug :) But don't want to be picky, important is to have tests!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment