Skip to content

Instantly share code, notes, and snippets.

@decrn
Last active February 16, 2019 17:17
Show Gist options
  • Save decrn/c66f25add07addc60fa4deb00462562c to your computer and use it in GitHub Desktop.
Save decrn/c66f25add07addc60fa4deb00462562c to your computer and use it in GitHub Desktop.
export const calcStringSum = string => {
if (!string) // trivial case
return 0;
if (string.indexOf('//') === 0) { // custom delimeter
const delimeter = string.split('\n')[0].replace('//', '');
return reduceByDelimeter(delimeter, string.split('\n')[1]);
}
return reduceByDelimeter(/[,\n]/, string); // default delimiters
}
const reduceByDelimeter = (delimeter, string) => {
return string
.split(delimeter)
.map(current => parseInt(current)) // parse values
.reduce( (acc, curr) => {
(acc > 1000) ? // ignore if bigger than 1000
curr : acc + curr // sum the rest
});
}
import { calcStringSum } from './calc';
const escape = (string) => {
return string.replace('\n', '\\n');
}
const expected = [
["", 0],
["5", 5],
["5,5", 10],
["1,2,3", 6],
["1\n24,5", 30],
["1,\n", NaN],
["//;\n2;2", 4],
["10000,5", 5],
["//[***]\n1***2***3", 6],
];
expected.map((values) => {
const value = values[0];
const expected = values[1];
test(`${escape(value)} should return "${expected}"`, () => {
expect(calcStringSum(value)).toBe(expected);
});
});

TDD workshop

Source: http://osherove.com/tdd-kata-1

String Calculator

  1. Create a simple String calculator with a method int Add(string numbers)
    • The method can take 0, 1 or 2 numbers, and will return their sum (for an empty string it will return 0) for example "" or "1" or "1,2"
    • Start with the simplest test case of an empty string and move to 1 and two numbers
    • Remember to solve things as simply as possible so that you force yourself to write tests you did not think about
    • Remember to refactor after each passing test
  2. Allow the Add method to handle an unknown amount of numbers
  3. Allow the Add method to handle new lines between numbers (instead of commas).
    • the following input is ok: 1\n2,3 (will equal 6)
    • the following input is NOT ok: 1,\n (not need to prove it - just clarifying)
  4. Support different delimiters
    • to change a delimiter, the beginning of the string will contain a separate line that looks like this: //[delimiter]\n[numbers…] for example //;\n1;2 should return three where the default delimiter is ‘;’ .
    • the first line is optional. all existing scenarios should still be supported
  5. Calling Add with a negative number will throw an exception negatives not allowed - and the negative that was passed.if there are multiple negatives, show all of them in the exception message.

stop here if you are a beginner. Continue if you can finish the steps so far in less than 30 minutes.

  1. Numbers bigger than 1000 should be ignored, so adding 2 + 1001 = 2
  2. Delimiters can be of any length with the following format: //[delimiter]\n for example: //[***]\n1***2***3 should return 6
  3. Allow multiple delimiters like this: //[delim1][delim2]\n for example //[*][%]\n1*2%3 should return 6.
  4. make sure you can also handle multiple delimiters with length longer than one char
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment