gistfile1.txt

Instead of this:

define set_fix {
  file_line { "$name":
    path   => "$name",
    line   => 'JAVA_HOME=${JAVA_HOME:-/usr/jdk64/jdk1.6.0_31}',
    match  => 'JAVA_HOME=.*/jdk1\.6\.0.*',
    ensure => "present",
  }
}
set_fix { set_fix { [ '/etc/hcatalog/conf.dist/hcat-env.sh', '/etc/pig/conf.dist/pig-env.sh', ]: }: }

I should try this:

$files_to_fix = {
  'hcat-env.sh' => { path => '/etc/hcatalog/conf.dist/hcat-env.sh' },
  'pig-env.sh'  => { path => '/etc/pig/conf.dist/pig-env.sh' },
}

$fix_default_attrs = {
  line   => 'JAVA_HOME=${JAVA_HOME:-/usr/jdk64/jdk1.6.0_31}',
  match  => 'JAVA_HOME=.*/jdk1\.6\.0.*',
  ensure => "present",
}

create_resources('file_line', $files_to_fix, $fix_default_attrs)